Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
block.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 May 2014 at 20:05 UTC
Updated:
29 Jul 2014 at 23:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettComment #2
benjy commentedHard to believe it was so simple, I really like this idea.
Comment #3
tim.plunkettAlso I should mention that I ran this by @EclipseGc before posting the issue, and he was +1.
Comment #4
berdirThis just makes the default implementation implement those methods, shouldn't BlockPluginInterface also extend ContextAwarePluginInterface?
Comment #5
eclipsegc commentedNo, I don't think so. There are changes coming to the BlockInterface (hopefully) but I don't think this needs to be amongst them. I'm ++ to this change, but I don't think the interface needs any updating. Blocks can be context aware w/o forcing all blocks to be context aware.
Eclipse
Comment #6
alexpottCommitted da13333 and pushed to 8.x. Thanks!
Comment #8
tim.plunkettThanks. Opened #2273381: Convert ContextAwarePluginBase to traits for a future generic solution.