Text Editor's in-place editing plugin broke in-place editing at large due to PHP fatal

I was wondering what that didn't work (anymore) :)

As did @EclipseGc in IRC...

+++ b/core/modules/editor/lib/Drupal/editor/Plugin/InPlaceEditor/Editor.php
@@ -78,10 +78,11 @@ public function getAttachments() {
     $formats = array();
     foreach ($user_format_ids as $format_id) {
-      $editor = editor_load($format_id);
-      $editor_id = $editor->getEditor();
-      if ($editor && isset($definitions[$editor_id]) && isset($definitions[$editor_id]['supports_inline_editing']) && $definitions[$editor_id]['supports_inline_editing'] === TRUE) {
-        $formats[] = $format_id;
+      if ($editor = editor_load($format_id)) {

Not specific to this fix, but wondering why this doesn't load all editors together and foreaches on that, then it simply won't do anything if there's nothing?

There is no editor_load_multiple(), but it can use the entity manager or entity_load_multiple().

#2190313: Add $EntityType::load() and loadMultiple() to simplify loading entities would help, which currently doesn't deprecate/replace entity_load() (please review that :))

Just learned a new thing

This looks pretty rtbc to me, and fixes a huge wtf imo.

Eclipse

Hah, I did notice this - thought it was my computer acting up.

Committed and pushed to 8.x. Thanks!

Notice: the default.settings.php change should have been part of #2241633: Simplify site-specific service overrides.

Nope, it was a notice for a mistake in webchick's commit http://drupalcode.org/project/drupal.git/commitdiff/5f79a75. And it's this issue ;)

Hm. Strange. Re-appled that hunk of the diff and committed and pushed to 8.x. Thanks!

I didn't mean a patch, just a note for whom who do git blame, because I thought that extra note had already been removed in #2241633: Simplify site-specific service overrides. But in fact no. I've just checked again in that issue, catch reverted the commit, but then undid that revert.

So this commit is actually good. Thanks.