Problem/Motivation

After #890362: Links should not be indicated by color only went in, the pager links look bad: the underlinings are too distant from the anchor, and tend to be not separated enough to distinguish between different links.

See screenshot:
pre

Proposed resolution

Move padding from the anchor styling to the pagers list item styling, to achieve this:

post

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 Screen Shot 2014-05-16 at 17.01.31.png15.47 KBemma.maria
#1 2256915-1.patch885 bytesmondrake
post.png2.19 KBmondrake
pre.png2.39 KBmondrake

Comments

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 2256915-1.patch885 bytes

Patch

mgifford’s picture

mgifford
he/him
Primary language English
commented

That looks like a big improvement.

emma.maria’s picture

emma.maria
she/her
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2014-05-16 at 17.01.31.png15.47 KB

The patch code looks sound and the pagers now look awesome!

  • Commit 2b31335 on 8.x by alexpott: 
    Issue #2256915 by mondrake: Fixed Pager link underlinings do not display...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2256915-1.patch, failed testing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Fixed

This can be marked fixed now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.