Improve Accessibility for String Translation UI

@Schnitzel: thanks for opening this issue. These fixes sound really great. I'll review the patch as soon as possible.

BTW, the patch failed testing, unfortunately. Do you think it can be reviewed in any case?

I just scanned through the code, but it looks good. I'll leave @falcon03 to do the testing, but happy with the changes I've seen.

We don't need this in the patch either:

old mode 100644
new mode 100755

Anyways, happy to see this was caught.

Eagerly awaiting testing feedback! :) Thanks!

Set this up:
admin/config/regional/translate/translate

Looks good except that there's a label without a form element on this page:

<label class="element-invisible" for="edit-strings-1-original">Source string (Built-in English)</label>
<span lang="en">Show all columns</span>

This probably should be a new issue though as it's really unrelated to the initial reported error.

@mgifford: well, the "Source text..." text is a regular form item #type, this is just how Drupal renders those (and those don't have a form element in general). Its the same before/after the patch also. Any other accessibility feedback or should this be ready to go once green?

No, it should be good when it's green. I reviewed the code and it's adding good text changes and semantic ones too.

Will have to hunt down the label separately. Labels need to be associated with form elements strictly in a 1 to 1 relationship.

tagging.

#1: 2004684-string-translation-ui-accessibility-1.patch queued for re-testing.

I think the test is failing here:
$this->assertNoText('English', t('No way to translate the string to English.'));

But not sure why it's failing as that text seems to exist in the source on /admin/config/regional/translate/translate

Source string (Built-in English)

Would like to get the test fixed.

@mgifford: before the patch, the source language name did not show in the UI. The test is asserting it DOES NOT show, and now it shows. So fails. The intent of that assert is to test if English shows up as an option in the "Translation language" select box. It does not show there, but it shows now on every page as part of the source string description.

So one quick fix would be to do something like:

$this->assertNoRaw('>English<', t('No way to translate the string to English.'));

Or if there is some specific method to check for an option existing in a select dropdown. Or if you want to pull out your xpath skills and do an assert xpath on the source to look for an option tag that has 'English' as text, those would be fancier. :)

Can you push this that little forward? Sounds like we are pretty close!

I tried the quick fix you expressed. Hopefully the bot likes it.

#18: 2004684-string-translation-ui-accessibility-18.patch queued for re-testing.

'Exception' with message 'The configuration directory type staging does not exist.' does not seem to be related to this patch at all :)

#18: 2004684-string-translation-ui-accessibility-18.patch queued for re-testing.

Ok, so this proves it works now :) Let's get in a real test assertion on it :)

I think something like this is more fancy to say the thing we are looking for to not be there:

$this->assertNoOption('edit-langcode', 'en', t('No way to translate the string to English.'));

This expresses that the edit-langcode select list does not have an 'en' option. More foolproof than just asserting for >English<. I just had time to look up this more fancy way, I don't easily recall the assert methods I don't regularly use :) Sorry for not coming with this option first :)

Filenames changed too. Thanks Gabor. Here's the new patch.

Looks all good to me as long as it passes :)

+++ b/core/modules/locale/locale.pages.inc
@@ -345,6 +347,8 @@ function locale_translate_edit_form($form, &$form_state) {
+              '#prefix' => $i == 0 ? ('<span class="element-invisible">' . t('Translated string (@language)',  array('@language' => $langname)) . '</span>') : '',

Here and elsewhere, the class name needs to be changed, because of #1363112: Simplify names of "element-x" helper classes.

Annoying.. Where's the search/replace on all existing patches to update strings like that.....

Thanks effulgentsia!

All righto!

Committed to 8.x. Thanks!

Woot, thanks @falcon03, @Schnitzel, @mgifford!

Yay!