Problem/Motivation

The page at admin/help/language in the second paragraph states:

Language negotiation allows your site to automatically change language based on the domain or path used for each request. Users may (optionally) select their preferred language on their My account page, and your site can be configured to honor a web browser's preferred language settings. Site content can be translated using the Content Translation module.

In this text the last three words (Content Translation module) refer to a faulty location: /admin/help/translation which does not exist in Drupal 8.

Proposed resolution

Revise the text and correct the link to /admin/modules#edit-modules-multilingual

Remaining tasks

User interface changes

None

API changes

None

Comments

tammo’s picture

hydra’s picture

Changing the link might solve the problem if the translation module is disabled, but if the translation module is enabled the translation help page will be available. So I would propose to show diffrent links, dependend of the context if the translation module ist enabled or not.

hydra’s picture

Status: Active » Needs work
StatusFileSize
new2.38 KB

Okay, first try to implement a context sensitive Help version for the language help, dependend on the content translation module be enabled.

I'm not sure if this is the way core handels such things, anyway we need a nicer text then "whatever".

attiks’s picture

+++ b/core/modules/language/language.moduleundefined
@@ -19,7 +19,14 @@ function language_help($path, $arg) {
+      $is_translation_module_enabled = module_exists('translation');
+      if($is_translation_module_enabled) {

you can combine this into 1 line since the variable is only used once.

+++ b/core/modules/language/language.moduleundefined
@@ -19,7 +19,14 @@ function language_help($path, $arg) {
+        $output .= '<dd>' . t("Language negotiation allows your site to automatically change language based on the domain or path used for each request. Users may (optionally) select their preferred language on their <em>My account</em> page, and your site can be configured to honor a web browser's preferred language settings. To be able to configure whatever, you need to enable the translation module
+        <a href='@content-help'>Content Translation module</a>.", array('@content-help' => url('admin/modules#edit-modules-multilingual'))) . '</dd>';

this should go on one line (no break after module)

"To be able to configure whatever" sounds strange to me

tammo’s picture

Proposal for new text:
============================
The three (four?) core modules about adding multiple languages to your site are:

  1. Locale (?)
  2. Language
  3. Interface translation
  4. Content translation

For configuring time zones and local settings please enable "Locale"
For adding languages to your site: enable "Language".
For making the user interface of your site appear in another language or in multiple languages: enable "Interface translation"
For defining content in multiple languages and translations: enable "Content translation"

After you have taken the above steps, configure the language settings at the following pages:

  • [link to /admin/config/regional/settings]Regional settings[/link]: for choosing the default language and several other settings
  • [link to /admin/config/regional/language/detection]Language detection and selection[/link]: decide how and when the site and content should be shown in what language
  • [link to /admin/structure/types]Content types[/link]: Enable content type translation (only when Content translation module is switched on)
  • [link to /admin/structure/block]Blocks[/link]: to enable the language selection blocks
Sethie’s picture

StatusFileSize
new1.9 KB
new2.36 KB

Patch in #3 didn't work for me, the link points to 'admin/modules%23edit-modules-multilingual'. Used url('admin/modules', array('fragment' => 'edit-modules-multilingual')) to create the link.
Also, the text was a bit too far fetched in my opinion.
Patch and interdiff attached.

Sethie’s picture

Status: Needs work » Needs review
StatusFileSize
new1.9 KB
new2.36 KB

Forgot to change status to needs review.

Sethie’s picture

Tested the patch on simplytest.me and it works, but there still seems to be a problem with the fragment (#) when using overlay. The module page renders, but does not scroll to the specific module.
If you're not using overlay, the module page renders correctly with the # fragment.
This might be a bug because I'm using the proper fragment option of the url function.

eugenesia’s picture

Issue summary: View changes
Status: Needs review » Closed (duplicate)
Issue tags: +LONDON_2014_JUNE
Related issues: +#2103039: Review hook_help for the language module

Closing this issue as it is obsolete. The module's help text was rewritten in #2103039: Review hook_help for the language module, resulting in removal of the erroneous link.