Problem/Motivation
The page at admin/help/language in the second paragraph states:
Language negotiation allows your site to automatically change language based on the domain or path used for each request. Users may (optionally) select their preferred language on their My account page, and your site can be configured to honor a web browser's preferred language settings. Site content can be translated using the Content Translation module.
In this text the last three words (Content Translation module) refer to a faulty location: /admin/help/translation which does not exist in Drupal 8.
Proposed resolution
Revise the text and correct the link to /admin/modules#edit-modules-multilingual
Remaining tasks
User interface changes
None
API changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | language-help-text-1998676-6.patch | 2.36 KB | Sethie |
| #7 | interdiff.txt | 1.9 KB | Sethie |
| #6 | language-help-text-1998676-6.patch | 2.36 KB | Sethie |
| #6 | interdiff.txt | 1.9 KB | Sethie |
| #3 | language-help-text-1998676-3.patch | 2.38 KB | hydra |
Comments
Comment #1
tammo commentedCorrecting tag
Comment #2
hydra commentedChanging the link might solve the problem if the translation module is disabled, but if the translation module is enabled the translation help page will be available. So I would propose to show diffrent links, dependend of the context if the translation module ist enabled or not.
Comment #3
hydra commentedOkay, first try to implement a context sensitive Help version for the language help, dependend on the content translation module be enabled.
I'm not sure if this is the way core handels such things, anyway we need a nicer text then "whatever".
Comment #4
attiks commentedyou can combine this into 1 line since the variable is only used once.
this should go on one line (no break after module)
"To be able to configure whatever" sounds strange to me
Comment #5
tammo commentedProposal for new text:
============================
The three (four?) core modules about adding multiple languages to your site are:
For configuring time zones and local settings please enable "Locale"
For adding languages to your site: enable "Language".
For making the user interface of your site appear in another language or in multiple languages: enable "Interface translation"
For defining content in multiple languages and translations: enable "Content translation"
After you have taken the above steps, configure the language settings at the following pages:
Comment #6
Sethie commentedPatch in #3 didn't work for me, the link points to 'admin/modules%23edit-modules-multilingual'. Used
url('admin/modules', array('fragment' => 'edit-modules-multilingual'))to create the link.Also, the text was a bit too far fetched in my opinion.
Patch and interdiff attached.
Comment #7
Sethie commentedForgot to change status to needs review.
Comment #8
Sethie commentedTested the patch on simplytest.me and it works, but there still seems to be a problem with the fragment (#) when using overlay. The module page renders, but does not scroll to the specific module.
If you're not using overlay, the module page renders correctly with the # fragment.
This might be a bug because I'm using the proper fragment option of the url function.
Comment #9
eugenesia commentedClosing this issue as it is obsolete. The module's help text was rewritten in #2103039: Review hook_help for the language module, resulting in removal of the erroneous link.