Background:
This issue is part of the meta-issue for updating the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules

Tasks:
a) [DONE - patch ready] review / write the hook_help text according to help guidelines http://drupal.org/node/632280
More details are on the meta-issue.

b) (novice) Final manual testing:
1. Apply the patch.
2. Go to admin/help.
3. Click on the help page for this module (Language).
4. Verify that the help page is OK:
- Verify that all the links work
- Verify that all mentions of pages/text/permissions within the UI match what is seen in the UI
- Verify that the formatting is OK.

Files: 
CommentFileSizeAuthor
#42 language-help-text-2103039-42.patch12.12 KBfran seva
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,804 pass(es).
[ View ]
#42 interdiff_2103039_41-42.txt2.72 KBfran seva
#41 language-help-text-2103039-41.patch12.06 KBfran seva
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,229 pass(es).
[ View ]
#41 interdiff_2103039_38-41.txt2.99 KBfran seva
#38 language-help-text-2103039-38.patch12.06 KBfran seva
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,622 pass(es).
[ View ]
#38 interdiff_2103039_31-38.txt6.9 KBfran seva
#31 language-help-text-2103039-31.patch12.8 KBfran seva
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,615 pass(es).
[ View ]
#28 language-help-text-2103039-28.patch12.85 KBfran seva
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,579 pass(es), 23 fail(s), and 120 exception(s).
[ View ]
#28 interdiff-2103039-21-28.txt8.8 KBfran seva
#21 language-help-text-2103039-21.patch12.93 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,983 pass(es).
[ View ]
#21 interdiff-2103039-17-21.txt8.06 KBifrik
#21 interdiff-2103039-13-21.txt233.42 KBifrik
#19 language-help-text-2103039-19.patch5.05 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,874 pass(es).
[ View ]
#19 interdiff-17-19.txt12.94 KBifrik
#17 language-help-text-2103039-17.patch8.18 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,882 pass(es).
[ View ]
#17 interdiff-13-17.txt228.66 KBifrik
#13 language-help-text-2103039-13.patch7.87 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,824 pass(es).
[ View ]
#13 interdiff-11-13.txt9.98 KBifrik
#11 language-help-text-2103039-11.patch7.83 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,802 pass(es).
[ View ]
#11 interdiff-9-11.txt8.55 KBifrik
#9 language-help-text-2103039-9.patch7.65 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,810 pass(es).
[ View ]
#9 interdiff-6-9.txt10.23 KBifrik
#6 language-help-text-2103039-6.patch6.84 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,829 pass(es).
[ View ]
#6 interdiff-2103039-4-6.txt9.32 KBifrik
#4 language-help-text-2103039-4.patch6.82 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,716 pass(es).
[ View ]
#2 language-help-text-2103039-2.patch6.42 KBifrik
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,658 pass(es).
[ View ]

Comments

ifrik’s picture

Issue summary:View changes

working on this during DrupalDevDays

ifrik’s picture

Status:Active» Needs review
StatusFileSize
new6.42 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,658 pass(es).
[ View ]

This is an initial re-write of the help text for the language module. Some things still need fixing:

  • I haven't figured out what the correct routing to is because I could find which module provides that page admin/config/regional/settings
  • I'm not sure what the "Account administration settings" in Detection and selection refers to, but I add later

I'm also not quite sure whether I've now covered everything that the language module does, but the text should work as a starting point.

jhodgdon’s picture

admin/config/regional/settings seems to be in core/modules/system/system.routing.yml.

ifrik’s picture

StatusFileSize
new6.82 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,716 pass(es).
[ View ]

Thanks jhodgdon!
I've added the link as well as the use "block visiblity"

jhodgdon’s picture

Status:Needs review» Needs work

Here's a catalog of what the Language module actually does/provides (from a UI perspective):
- Managing languages (add/delete/edit individual languages and an Overview page at admin/config/regional/language -- route language.admin_overview)
- Language detection/selection settings (admin/config/regional/language/detection -- route language.negotiation -- and quite a few sub-pages for configuring individual selection/detection methods)
- Content language settings page (admin/config/regional/content-language -- route language.content_settings_page)
- Language switcher block

So, we should make sure all of these are covered in this help text, and nothing else.

Some other thoughts on this latest patch:

a)

The Language module allows you to maintain a list of languages used on your site...

I think we should not say that you are "maintaining a list of languages". That is kind of weak -- and why would anyone care about maintaining a list? What it really allows you to do is configure the languages used on your site.

b) Make sure the pages referred to in the help are the same as the actual page titles. Most have "Sentence case" capitalization, I think, not "Title Case". For instance, I saw "... Languages List page..." in the help, but the page is actually just called "Languages". And then later in that paragraph, you refer to the language being "shown in the Languages List" -- I don't think that needs capitalization at all.

c)

... language code, name and direction ...

Needs comma after "name".

d)

... and a tick box to display language selectors. ...

Tick box is not the right term. I think it is a set of checkboxes?

e)

... is displayed on the content creation pages. ...

No "the" needed here.

f)

... for any supported content element of your site (for example for content types or user profiles).

This should be "entity" not "content element", and I don't think we refer to anything as "user profiles" any more?

g) Be careful about URLs that go into other modules. For instance, the Block module is no longer required, so if you want to include a Block module URL, you have to check whether it is installed (and also you should say in the text something like "... if the Block module is installed..."). There are examples of this in the Menu module help.

h) I don't understand why the help text recommends not changing the default site language.

i)

... provides several methods  by which the site detects in which language to display interface text ...

This is a bit awkward... In English, it is actually preferable to say "which language to display interface text in" rather than putting the "in" first. And the "by which" part would be better as "provides several methods for detecting..."

j) There are some extra spaces here and there, like:

...specified for each language. '

Thanks!

ifrik’s picture

StatusFileSize
new9.32 KB
new6.84 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,829 pass(es).
[ View ]

Thanks, I've taken up the issues.
The phrase "content element" came from the help text displayed directly on the Content language page. I think there is quite a lot of help text _on_ the pages, that probably should be checked for phrases like that. The same goes for the page names: There is a bit of inconsistency about whether the page titles are the same as the selected tab or not, and some of them are very generic (for example "Import" or "Settings") so usability starts to become an issue, and should be taken up at another point.

jhodgdon’s picture

Looking better!

A few notes:

1. Uses #1

If the <a href="!interface">Interface Translation module</a> is installed, then interface translation for this language is automatically downloaded as well.

The truth of this statement depends on how you have the Interface Translation module configured, at least according to your latest locale help patch (I think you can turn this on/off, right?). So... not sure what to say here...

2. Uses - Content language

...customize the language settings for any supported content entity of your site...

of ==> on

3. Same Uses bullet

Customizing content languages settings

We have a UI text guideline that says to use the word "configure" rather than "setting". So this header should probably be changed?
https://drupal.org/node/604342

4. Language switcher block uses

array('!blocks' => \Drupal::url('block.admin_display')

This is not going to work. If the Block module is not installed it will cause an error. See my earlier comment -- need to do what is done in the Menu module help code to check if Block is installed.

5. Please get rid of "by which" throughout.

6. Extra spaces: " specifing de for German would result..."

7.

+      $output .= '<li>' . t('<em>Account administration pages</em> sets the interface language based on the language that is set for the specific user on their user page.') . '</li>';

Is this right? It seems like this is "user" setting documentation?

ifrik’s picture

Thanks.
I've also looked at the style guide with Lewis, and in the next days I'll look at the interface texts and page and tab titles wiith people from the Multilingual sprint to see what needs changing.
After that I'll run through these help texts again.

ifrik’s picture

Status:Needs work» Needs review
StatusFileSize
new10.23 KB
new7.65 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,810 pass(es).
[ View ]

I've added the checking whether modules exist to all the references where it says "if enabled...", and taken up the comments above.
The "administration language" is a bit weird, but correct like that. Administrators can add a second language for administrating the site - which is a great option for site builders. However, if the detection method is not enabled, then that field is hidden from the user profile. I've added that to the help text.
The name of that method is somewhat weird as well, and the Multilingual Initative would be happy to replace it with something better.

And sorry, the interdiff might be a bit messy, due to issues with pulling Head in between.

jhodgdon’s picture

Status:Needs review» Needs work

Thanks, looks good! A few typos and minor fixes:

a) in 'Setting administration languages'

method is enable on the

enable => enabled

b) This "administration languages" Uses item seems a bit out of place. It is currently before the "Selection and Detection" stuff is even described, and before any other mention that people can even set a language for themselves. I like the wording, but... maybe it should be moved a bit? Not sure where... Or maybe it just needs a little more explanation?

c) Detection and Selection section:

...page provides several methods to detect in which language interface text is displayed.

===>
page provides several methods for deciding which language should be used for displaying interface text.
(does that sound better? It does to me)

d) Same section - You might want to mention that you choose methods and order them, and the first method that provides an answer is selected?

e) Session item in this section:

...determines the interface language for a request or session parameter.

for => from?

f) same item

...use of <em>de</em> within the <em>language</em> parameter.

within => as?

g) Administration item within that section:

and the interface text language then follows that configuration.

This area doesn't explicitly say that it only applies to administration pages?

ifrik’s picture

Status:Needs work» Needs review
StatusFileSize
new8.55 KB
new7.83 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,802 pass(es).
[ View ]

Thanks,
I've taken the comments up, removed the additional idents that crept in at the last patch, and fixed some typos.

I've moved the administration page language just above the longer "Detection and selection" section. To keep them closer together.
In other cases, I would just refer to it in the "Detection..." section, but the second language field on the profile page is hidden, when this method is not available - something that's very easy to overlook and I feel that it deserves the extra attention.

batigolix’s picture

Status:Needs review» Needs work
Parent issue:» #1908570: [meta] Update or create hook_help() texts for D8 core modules

Impressive rewrite!

I reviewed the patch:

- formatting is Okay

I found a couple of small things

a) missing closing </td>

      $output .= '<dt>' . t('Language detection and selection');

b)

by clicking on Add language

I would prefer something like:

by selecting Add language

c)

then interface translation

I would prefer:

then the interface translation

d)

By default content is created

I would add a comma for readability:

By default, content is created

e)

Drupal::moduleHandler()->moduleExists('configuration_translation')

Should be:

Drupal::moduleHandler()->moduleExists('config_translation')

?

f)

you can add a language switcher block on the Block layout page to your site

I think we can do without "to your site". It makes the sentence easier to read:

you can add a language switcher block on the Block layout page

g)

The first method that detects which language to select is applied, so you can order the methods with your preferred method at the top of the list, and a fall-back option last.

this is a bit wonky. how about:

The methods for selecting a language can be ordered by importance. You can order the methods with your preferred method on top of the, followed by the fall-back methods.

h)

URL sets the interface language based on a path prefix or domain. (For example specifying de for German would result in URLs like example.com/de/contact.)

Punctuation seems weird to me, I'd prefer:

URL sets the interface language based on a path prefix or domain (for example specifying de for German would result in URLs like example.com/de/contact).

This occurs twice.

g) Should we mention "Content language detection" as well here? You only mention interface text translation ...

ifrik’s picture

Status:Needs work» Needs review
StatusFileSize
new9.98 KB
new7.87 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,824 pass(es).
[ View ]

Thanks,
I've taken the comments up. With the Detection and selection, we need to explain that once an interface language has been selected, the other methods aren't used. I hope it flows better now.

The Content language selection is not covered here because that's provided by the Content translation module (and I forgot we forgot it there...)

jhodgdon’s picture

Status:Needs review» Needs work

Thanks! But I think this still needs a bit of work, sorry...

a)

If the Blocks module is enabled

The module is called "Block", not "Blocks" now.

b) I'm still having trouble with this part:

+      $output .= '<dt>' . t('Setting administration languages') . '</dt>';
+      $output .= '<dd>' . t('If the <em>Account administration pages</em> method is enabled on the <a href="!detection">Detection and selection</a> page, then each administrator can set a second language on their profile page to use for site administration.', array('!detection' => \Drupal::url('language.negotiation'))) . '</dd>';

So, this appears before the section on Detection and Selection, and it refers to a "second language", when as far as I can see, the "first language" hasn't been explained.

Maybe we should replace this with "Setting user languages", and explain that users can select maybe a prefered language and maybe an administration language (both of those settings can apparently be turned off?), and that both of them can be used for detection and selection optionally (see below)? [the "see below" would at least clue people in that the explanation of detection and selection is coming up]

c)

for German  would result

(in URL under Detection and selection) --> Empty space before "would" here.

d) In Session detection item:

based on the use of <em>de</em> as <em>language</em> parameter

needs "the" after "as" here.

e) User detection item:

follows the user\'s language configuration set on the user\'s profile page.

How about omitting the first "user's"?

f) Administration detection item:

then administration users  can add a second language on their profile page.

administration => administrative
add => configure
second => ... Again, I don't think it makes sense to say "second" here. What does it say in the UI? Use that text?

g) Selected detection item:

or a specific language as fall-back language

Needs 'the' after 'as'

batigolix’s picture

Component:documentation» language.module

Changing component to get feedback from maintainers

ifrik’s picture

Good idea to make a use "Setting user languages".

How about:

Setting user language
Users can set a Site language on their profile page. This language is used for email messages, and can be used by modules to determine a user's language. It can also be used for interface text, if the User method is enabled as a Detection and selection method (see below). Administrative users can set a separate Administration pages language to be used for interface text on administration pages. This configuration is only available on the user's profile page if the Account administration pages method is enabled (see below).

Language detection and selection
...

ifrik’s picture

StatusFileSize
new228.66 KB
new8.18 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,882 pass(es).
[ View ]

Taken up the previous comments, removed white space.

I think the user languages works like that, but if somebody has a better proposal to rephrase that section then I'll be happy to hear it.

ifrik’s picture

Status:Needs work» Needs review
ifrik’s picture

StatusFileSize
new12.94 KB
new5.05 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,874 pass(es).
[ View ]

No changes to the text, but I've also fixed the links for the cases. The interdiff-17-19 only covers these.

The UI text is not changed but will need to be edited at some stage, because it doesn't fit with the style guide and for example refers to "Drupal" instead of to "your site".

jhodgdon’s picture

Status:Needs review» Needs work

Um. The patch in #19 lost most of the patch from #17 (most of the help changes are missing)? And the 13-17 interdiff is for some other patch I think?

I'll wait to review until we have the patches/interdiffs you intended here.

ifrik’s picture

Status:Needs work» Needs review
StatusFileSize
new233.42 KB
new8.06 KB
new12.93 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,983 pass(es).
[ View ]

That was most certainly messy....
So here is the patch with the both the new text as it was in patch 17 and the changes to the link in patch 19. Since there wasn't any review, I add an interdiff for 13 and 17

jhodgdon’s picture

OK, that was thorough of you. :)

So I looked through the patch in #21. It looks great!

Do we want to edit the text in the case: section of the hook_help now?
- We shouldn't be using Drupal in there ( case 'admin/config/regional/language/detection/browser')
- Need "the" at the start of this sentence: "Default language can be changed at the Regional settings page." (case 'admin/config/regional/language/detection')
- Last case: "(eg." should be "(for example, " or else "(e.g., "

Didn't see any other problems...

jhodgdon’s picture

Issue summary:View changes
Issue tags:+Novice, +Needs manual testing

Anyway, this is probably ready for a manual test - updated the issue summary.

Gábor Hojtsy’s picture

Issue tags:+D8MI, +language-base

Tagging with D8MI topic tags.

jhodgdon’s picture

Status:Needs review» Needs work

We just had a change to hook_help, on this issue: #2183113: Update hook_help signature to use route_name instead of path.

Here is the change record: https://drupal.org/node/2250345

This patch will need a reroll for this change.

fran seva’s picture

@ifrik I'm going to start to work in manual test but first It's needed a reroll. Any problem if I do the reroll for your patch?

jhodgdon’s picture

@fran seva: I am pretty sure ifrik will not mind. She's been working on a lot of patches for these issues in collaboration with a lot of people. Please do!

fran seva’s picture

Status:Needs work» Needs review
StatusFileSize
new8.8 KB
new12.85 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,579 pass(es), 23 fail(s), and 120 exception(s).
[ View ]

@jhodgdon attach reroll patch and interdiff.
In the rerolling, I have merged the @ifrik code with last code.
I'm not sure about the interdiff, I've followed the instruction in https://drupal.org/documentation/git/interdiff

jhodgdon’s picture

Status:Needs review» Needs work

Yeah, don't worry about an interdiff... if you are rerolling a patch because some underlying code has changed, you cannot really make an interdiff that is useful.

So... This change at the top of your new patch is not good:

+++ b/core/modules/language/language.module
@@ -1,4 +1,4 @@
-<?php
+  <?php

Can you take those two spaces back out please?

You also apparently added an extra lines that is not needed, here:


+
     case 'language.admin_overview':

Other than those two spots, the reroll looks OK. Thanks!

The last submitted patch, 28: language-help-text-2103039-28.patch, failed testing.

fran seva’s picture

StatusFileSize
new12.8 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,615 pass(es).
[ View ]

@jhodgdon thanks for your review!!
here is the new patch without wrong spaces but I think the patch will not pass the tests. The new one is the same that the wrong, just for the spaces.

fran seva’s picture

Status:Needs work» Needs review
jhodgdon’s picture

Status:Needs review» Needs work

Actually, I think the extra spaces before the <?php at the beginning of the file could cause errors. Those spaces would be output at the top of any page that includes the module file, and that is consistent with the test failures on your previous patch. So I think the reroll is correct now. Thanks!

Anyway... Looking at this new patch, I see that between when patch #21 was submitted and now, someone else changed the Language help in this section:

      case 'language.admin_overview':

Patch #31 is removing this line:

-      return '<p>' . t('Reorder the added languages to set their order in the language switcher block and, when editing content, in the list of selectable languages. This ordering does not impact <a href="@detection">detection and selection</a>.', array('@detection' => url('admin/config/regional/language/detection'))) . '</p>';

Patch #21 was removing this line:

-      return '<p>' . t('With multiple languages enabled, registered users may select their preferred language and authors can assign a specific language to content. The selection of what language is used to display page elements is made depending on the detection menthod settings in the <a href="@detection">Detection and Selection</a> tab.', array('@detection' => url('admin/config/regional/language/detection'))) . '</p>';

And both patches are replacing the removed line with this line:

+      return '<p>' . t('With multiple languages enabled, registered users may select their preferred language and authors can assign a specific language to content. The selection of what language is used to display page elements is made depending on the detection menthod settings in the <a href="!detection">Detection and Selection</a> tab.', array('!detection' => \Drupal::url('language.negotiation'))) . '</p>';

I think maybe that we should keep the current help that is in Drupal Core for this page, and take this change out of the patch entirely, because it seems like more correct information.

And here were some other comments I made in #22, for the specific-page section of the hook_help:

- We shouldn't be using Drupal in there ( case 'admin/config/regional/language/detection/browser')

- Need "the" at the start of this sentence: "Default language can be changed at the Regional settings page." (case 'admin/config/regional/language/detection')

- Last case: "(eg." should be "(for example, " or else "(e.g., "

fran seva’s picture

Ok @jhodgdon. I thought that @ifrik changes in "case 'language.admin_overview':" were the last one and valid. I will remove the changes related to language.admin_overview in the patch keeping the last committed version.
I'll review the text taking into account your comments in #22.
thanks for review!!

fran seva’s picture

@jhodgdon I have:
- modified the patch to not replace the case 'language.admin_overview'.
- replaced "eg" for "e.g.,"
- added "The" at the beginning of the sentence "Default language can be changed at the..."

But I'm not sure about the use of Drupal. Should I replace Drupal for another word as System or remove it? or Would be better change a little the sentence, for example, instead of "Define how to decide which language is used to display page elements (primarily text provided by Drupal and modules" change it for, "Define how to decide which language is used to display page elements (primarily text provided and modules".

jhodgdon’s picture

Let's see. The text says ... "(primarily text provided by Drupal and modules,..." -- here it should probably just say "primarily text provided by modules". I think that is what you meant?

fran seva’s picture

@jhodgdon, yepa. That was what I meant.
I'll change the texts.
Thanks!!

fran seva’s picture

Status:Needs work» Needs review
StatusFileSize
new6.9 KB
new12.06 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,622 pass(es).
[ View ]

Changes and interdiff:
changes:
- modified the patch to not replace the case 'language.admin_overview'.
- replaced "eg" for "e.g.,"
- added "The" at the beginning of the sentence "Default language can be changed at the..."
- Remove Drupal word from texts.

jhodgdon’s picture

Status:Needs review» Needs work

I think this patch is looking really really good!

I read through the whole thing, and I think it could use just this one small change. In the Uses section about detection and selection:

If the language detection is done by domain name, a URL needs to be specified for each language.

I think it should say "... a domain needs to be specified..." here, not a URL?

Also, this patch still needs a manual test. See issue summary for instructions.

fran seva’s picture

@jhodgdon I'll change it and I'll start with the manual test. In the last D8MI meeting @GaborHojtsy proposed me work in this issues and run the manual test :)
Thanks for review!!!

fran seva’s picture

Status:Needs work» Needs review
StatusFileSize
new2.99 KB
new12.06 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,229 pass(es).
[ View ]

patch and interdiff, changing URL for domain.
Next step manual testing.

fran seva’s picture

StatusFileSize
new2.72 KB
new12.12 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,804 pass(es).
[ View ]

Manual test review:
1. Apply the patch:
Patch applied language-help-text-2103039-41.patch #41

(Active All multilingual modules)

2. Go to admin/help. OK
3. Click on the help page for this module (Language). OK
4. Verify that the help page is OK:
- Verify that all the links work : At this step the test fails. The link to Detection and selection redirect to Page not found.
Reviewing the code I see that the t() doesn't have the placeholder for !detection. I have change it and create a patch (attached in the comment) in which the link is working.

$output .= '<dd>' . t('The <a href="!detection">Detection and selection</a> page... ',
array('!detection' => \Drupal::url('language.negotiation')));

- Verify that all mentions of pages/text/permissions within the UI match what is seen in the UI
I see that all mentions of pages/text/buttons are corrects. I have seen that in Adding custom languages text section, Languages is being reference but there is no link to Languages. IMHO, as a supposed new user reading the help text I expect a link where I could add the language and check in the drop down list the Custom language option.
- Verify that the formatting is
I don't see errors.

rodrigoaguilera’s picture

Assigned:Unassigned» rodrigoaguilera
Issue tags:+DrupalCampSpain
rodrigoaguilera’s picture

Assigned:rodrigoaguilera» Unassigned
Status:Needs review» Reviewed & tested by the community

I did all the verifications and checked that the last change from fran seva is ok.

I think that the link to Languages from the Adding Languages section is enough.

jhodgdon’s picture

Thanks for the updates and testing! We are in "critical and major commits only" period until after Wednesday when the next Alpha is released. So, this can get committed on Thursday or later.

fran seva’s picture

I think this issue should wait until we get feedback about what to do with "Drupal translation server" sentence [1]

[1] https://drupal.org/node/1861930

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 42: language-help-text-2103039-42.patch, failed testing.

fran seva’s picture

I'm on it

fran seva’s picture

Status:Needs work» Needs review
fran seva’s picture

Status:Needs review» Needs work

After retest the patch, it's green. Change the state to needs work, we are waiting feedback from #1861930: Use "Drupal translations website" instead of Drupal translation server or Community translation server

Gábor Hojtsy’s picture

Status:Needs work» Needs review

Not sure we should block this on that. That issue looks like going nowhere. We can fix this here and still amend it with Drupal or without Drupal mentioned on that issue.

bendev’s picture

I have applied #42 - I read the texts It seems clear to me.

As a new D8 user , I could apply the indications given here to translate a content type but I didn't succeed to translate menu links.
This text didn't help me to find a solution. (but I am not sure if this is because I am still missing something or because of another issue)

I chose "current interface language" for the main navigation menu and checked
"Show language selector on create and edit pages"
If I check "Enable translation" and save it, this option appears unchecked after page reload (no idea if this is normal)
when I edit a menu link I see the dropdown to select a language...

jhodgdon’s picture

Status:Needs review» Reviewed & tested by the community

Agreed with Gabor, let's not wait on the decision on that other issue about "Drupal translation server".

The comments in #52 seem to be a separate issue about whether the translation UI works, not about this patch. Please file a separate issue.

So I think we are back to RTBC here, as this patch has been tested and verified.

Thanks!

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks again everyone! Committed to 8.x.

  • Commit 13a22cf on 8.x by jhodgdon:
    Issue #2103039 by fran seva, rodrigoaguilera, Gábor Hojtsy, ifrik,...
Gábor Hojtsy’s picture

Yay, thanks all!

fran seva’s picture

yeah!! 1 of 4 hook_help issues fixed :)

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.