Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
taxonomy.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2013 at 21:50 UTC
Updated:
29 Jul 2014 at 22:13 UTC
Jump to comment: Most recent file
Comments
Comment #1
andypostTrying to keep it simple
Comment #2
andypostmissed hunk
Comment #4
andypostFix the rest places
Comment #5
larowlanunrelated?
Apart from that looks good.
Comment #6
andypostMerged properly, this one from commit #1975150: Remove variable_get from mymodule_shortcut_admin_default_set in the shortcut.api.php
Comment #7
andypost#6: 1978112-taxonomy-path-6.patch queued for re-testing.
Comment #8
ParisLiakos commentedconsistency++
but needs a reroll..otherwise looks good
Comment #9
andypostBetter to re-roll this patch after #1946456: Convert taxonomy_term_confirm_delete() and taxonomy_vocabulary_confirm_delete() to the new form interface
Comment #11
andypostOnce other one needs work let's normalize path
Comment #12
dawehnerAwesome! I went through the changes and every single line looked perfect!
Comment #13
andypostWith this one we can close #843162: Creating vocabularies with machine-names "List" or "Add" breaks links in taxonomy overview admin area. or backport to 7.x
Comment #14
webchickI was a bit alarmed to see a big hunk of validation logic removed with no replacement until I realized how totally effing janky said validation is and I'm really glad we don't need it anymore. ;)
Committed and pushed to 8.x. Thanks!
Wouldn't hurt to have a change notice for this, for modules whose documentation or whatnot might be pointing to the old URLs.
Comment #15
littlecodingWrite a API change notification
Comment #16
littlecodingSummary
The Drupal taxonomy admin path was converted to follow other core entity admin patterns with the addition of "manage" to the admin path.
Drupal 7
Drupal 8
Comment #17
littlecodingA change record node has been created
http://drupal.org/node/1986784
Comment #18
larowlanChanges record looks good
Comment #19
star-szrThis is fixed now, reverting tags and title. Thanks @LittleCoding!
Comment #20.0
(not verified) commented#843162: Creating vocabularies with machine-names "List" or "Add" breaks links in taxonomy overview admin area.