Subtask of #1775842: [meta] Convert all variables to state and/or config systems. Removed the variable_get as as far as I can see the hook just needs to return a string so just showing that should be clear enough I think with the comment above.

CommentFileSizeAuthor
#5 shortcuts-followup-1975150-5.patch521 bytesDavid_Rothstein
#1 1975150-shortcut_remove_variable_get-cmi-drupal-1.patch555 bytesACF

Comments

ACF’s picture

ACF commented
Status: Active » Needs review
StatusFileSize
new 1975150-shortcut_remove_variable_get-cmi-drupal-1.patch555 bytes

Patch.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

David_Rothstein’s picture

David_Rothstein commented
Status: Fixed » Needs work

It's impossible to create a shortcut set with a machine-readable name that looks like that (at least through the UI), so I don't think that code really works.

It's also a little odd to return a hardcoded string there (would only really ever make sense in custom code, rather than a contrib module) but I guess we can let that slide.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new shortcuts-followup-1975150-5.patch521 bytes

This switches to using a more likely (and legal) machine-readable name for the example shortcut set.

I think I can RTBC my own patch here...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: configuration system » documentation
Status: Reviewed & tested by the community » Fixed

D'oh! Thanks, David.

Committed and pushed to 8.x. Again. :)

Automatically closed -- issue fixed for 2 weeks with no activity.