Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Subtask of #1775842: [meta] Convert all variables to state and/or config systems. Removed the variable_get as as far as I can see the hook just needs to return a string so just showing that should be clear enough I think with the comment above.
Comment | File | Size | Author |
---|---|---|---|
#5 | shortcuts-followup-1975150-5.patch | 521 bytes | David_Rothstein |
#1 | 1975150-shortcut_remove_variable_get-cmi-drupal-1.patch | 555 bytes | ACF |
Comments
Comment #1
ACF CreditAttribution: ACF commentedPatch.
Comment #2
catchComment #3
webchickCommitted and pushed to 8.x. Thanks!
Comment #4
David_Rothstein CreditAttribution: David_Rothstein commentedIt's impossible to create a shortcut set with a machine-readable name that looks like that (at least through the UI), so I don't think that code really works.
It's also a little odd to return a hardcoded string there (would only really ever make sense in custom code, rather than a contrib module) but I guess we can let that slide.
Comment #5
David_Rothstein CreditAttribution: David_Rothstein commentedThis switches to using a more likely (and legal) machine-readable name for the example shortcut set.
I think I can RTBC my own patch here...
Comment #6
webchickD'oh! Thanks, David.
Committed and pushed to 8.x. Again. :)