Make System module active config save format match the default yml file. [#1942168]

Comment	File	Size	Author
#2	1942168-system-config-fix-1.patch	2.02 KB	vijaycs85

Comment #1

vijaycs85

London, UK

commented 13 March 2013 at 18:37

Title:

Make OpenID module active config save format match the default yml file.

» Make System module active config save format match the default yml file.

Log in or register to post comments

Comment #2

vijaycs85

London, UK

commented 14 March 2013 at 05:50

Status:

Active

» Needs review

Status	File	Size
new	1942168-system-config-fix-1.patch	2.02 KB

system.date.yml - using single quotes for escaping and double codes for string - Replace singlequotes with "\".
system.file.yml - active storage has no comment in it.

Log in or register to post comments

Comment #3

sidharthap

English

commented 16 March 2013 at 12:24

Thanks @Vijaycs85, It looks good for system.authorize.yml, system.mail.yml, system.maintenance.yml, system.menu.yml and for other files i found some issues.
1 - Some places it is removing single quotes (system.date.yml)
2 - Escapeing the escape charater (Ex: T) in date format. (system.date.yml)
3 - Comments line removes in active config. (system.file.yml)

Log in or register to post comments

Comment #4

sidharthap

English

commented 16 March 2013 at 12:28

Status:

Needs review

» Needs work

Changeing status to needs work as per #3.

Log in or register to post comments

Comment #5

vijaycs85

London, UK

commented 16 March 2013 at 12:47

Status:

Needs work

» Needs review

Thanks @sidharthap. here some updates on individual points

#3.1 - Yes, Yaml does that, but for consistency we use single quotes for data that can get space or ':'.
#3.2 - Created a new issue #1944636: PECL Intl extension usage in DateTimePlus class broken and untested
#3.3 - Guess, we are fine with comments.

Setting it to needs review as we don't have anything to fix in this issue for #3.