Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
14 Jan 2013 at 02:46 UTC
Updated:
29 Jul 2014 at 21:46 UTC
Jump to comment: Most recent file
Since #1608842: Replace list of bootstrap modules, enabled modules, enabled themes, and default theme with config, update_retrieve_dependencies() no longer considers disabled modules.
No test coverage for it either
Patch and test to follow.
Comments
Comment #1
larowlanNote that .pass patch won't pass as there are un-resolved dependencies in HEAD.
Actual .pass patch will need to fix those too.
Comment #2
larowlanComment #4
larowlansomething not right, will re-visit test when I have a clean head
as mentioned the fail is expected in the .pass test, just not the pass in the .fail test (if that makes sense)
Comment #5
larowlanYeah test is dud, update_test_1_8002 runs before user_update_8016 even though update_test_1_update_dependencies() is *NOT* invoked.
New test just sets a state variable when update_test_1_update_dependencies() runs and checks for that in the test.
Here is new .fail and .pass patches.
Comment #6
catchFix looks good.
I added it to the issue summary at #1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed.
Comment #7
larowlanNote this blocks #1871772: Convert custom blocks to content entities
Comment #8
webchickCommitted and pushed to 8.x. Thanks!