Remove file.inc ties and fix unlink while at it in MTimeProtectedFastFileStorage

Added a protected method MTimeProtectedFastFileStorage::unlink() with the same code as drupal_unlink() uses.
According to my regex search (drupal_basename|drupal_chmod|drupal_dirname|drupal_mkdir|drupal_move_uploaded_file|drupal_realpath|drupal_rmdir|drupal_tempnam|drupal_unlink|file_build_uri|file_create_filename|file_create_url|file_default_scheme|file_delete|file_delete_multiple|file_destination|file_directory_temp|file_download|file_ensure_htaccess|file_get_mimetype|file_get_stream_wrappers|file_munge_filename|file_prepare_directory|file_save_htaccess|file_save_upload|file_scan_directory|file_stream_wrapper_get_class|file_stream_wrapper_get_instance_by_scheme|file_stream_wrapper_get_instance_by_uri|file_stream_wrapper_uri_normalize|file_stream_wrapper_valid_scheme|file_transfer|file_unmanaged_copy|file_unmanaged_delete|file_unmanaged_delete_recursive|file_unmanaged_move|file_unmanaged_save_data|file_unmunge_filename|file_upload_max_size|file_uri_scheme|file_uri_target|file_valid_uri)
the call to file_save_htaccess() is the only dependency left to file.inc
However I'm not sure how to solve that, shall we duplicate more code? :|

Next version after a talk in IRC with aspiliciious & chx.

[14:24] <chx> das-peter: can you get rid of the recursive delete call?
[14:30] <chx> das-peter: so http://privatepaste.com/801d135116 this is how you can do a recursive delete but i am not sure how to make this work w/ the chmod you need to do :(
...
[14:34] <chx> das-peter: it's in FileStorage
[14:34] <chx> das-peter: deleteAll
[14:34] <chx> das-peter: nevermind, then, let's do it in a separate issue (but if you feel up to it, please please do!)

I changed quite a bit now (besides the coding standard fixes):

• I've added a method FileStorage::unlink(), this basically does the same as drupal_unlink() - ensure the file can be deleted.
• FileStorage::deleteAll() now uses SPL iterators and objects to do it's job. Behaviour is the same as in file_unmanaged_delete_recursive(). However, I'm not sure if the watchdog part is necessary.
• MTimeProtectedFastFileStorage::saveHtaccess() is the replacement for file_save_htaccess(), I stripped all the stuff I thought is unrelated.

IRC Log:

[15:38] <chx> das-peter: isnt that a fatal?
[15:38] <chx> das-peter: public static function filePreDeleteCallback($path) {
[15:39] <chx> das-peter: $this->filePreDeleteCallback($this->directory);
[15:39] <chx> das-peter: static::filePreDeleteCallback($this->directory); would be my guess
[15:39] <das-peter> chx: What the heck?! I tested that and got no errors. That's not good and anyway, I don't think it needs to be static anymore...

...

[15:49] <chx> das-peter: oh and watchdog , get rid of that
[15:49] <chx> das-peter: nothing Drupal-y please.

Done as said.

Added check if dir is a dot.

Next re-roll:
- Removed use for SPL classes.
- Changed htaccess code to the example in #1849004: One Service Container To Rule Them All
- Fixed deleteAll, I've to use $iterator and not $file to do the dot check.

Re-rolled.

[12:52] <das-peter> chx: Hi, looks like you were right about the permissions in FileStorage::deleteAll(), I could add another utility class which extends RecursiveIteratorIterator to set the permissions before accessing / deleting the child items.
[12:52] <chx> das-peter: i thought that will be needed :/ is that better than a recursive php function?
[12:54] <das-peter> chx: I'm not sure if it's better. Just thought you like the RecursiveIteratorIterator and thus I should keep that ;)
[12:55] <chx> das-peter: skip the iterators
[12:56] <chx> das-peter: PHP 5.4 has http://www.php.net/manual/en/class.recursivecallbackfilteriterator.php but we cant use , skip em
[12:56] <chx> das-peter: just use a recursive method done
[12:56] <das-peter> chx, okay, so I'll clone the existing one and strip what ever possible.
[13:07] <chx> das-peter: yeah
[13:08] <chx> das-peter: check my htaccess code, that's how far you can get
[13:08] <chx> das-peter: those file.inc methods, boy, those are complicated
[13:09] <das-peter> chx: do you've another patcht? I thought I've implemented the latest version you made.
[13:09] <chx> ah yes
[13:09] <chx> you did
[13:09] <chx> good :)

Refactoring.

[13:33] <chx> das-peter: cos unlink and deleteRecursive call only fieldPreDeleteCallback and so the latter can be inline into the code in deleteRecursive , you decide what to call it, i think the parent class has an unlink, no? so unlink to overrde parent might be better? really, your choice