The file default.settings.php has apparently been made executable by accident in #1184472: Adding rel="author" to "Submitted by" link (commit 4db35f75740). This file should not be executable.

CommentFileSizeAuthor
#11 1830330-1-core-default_settings_php_executable.patch490 bytesDavid_Rothstein
#4 1830330-4-core-file_permissions.do_not_test.patch3.31 KBpfrenssen
#1 1830330-1-core-default_settings_php_executable.patch490 bytespfrenssen

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
commented
StatusFileSize
new 1830330-1-core-default_settings_php_executable.patch490 bytes
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
kotnik’s picture

kotnik commented
Status: Needs review » Needs work

While at it, could you also include these files which are executable for no reason:

./core/misc/ui/themes/base/images/ui-icons_222222_256x240.png
./core/misc/ui/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png
./core/misc/ui/themes/base/images/ui-bg_glass_75_dadada_1x400.png
./core/misc/ui/themes/base/images/ui-icons_888888_256x240.png
./core/misc/ui/themes/base/images/ui-bg_glass_65_ffffff_1x400.png
./core/misc/ui/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png
./core/misc/ui/themes/base/images/ui-icons_cd0a0a_256x240.png
./core/misc/ui/themes/base/images/ui-bg_glass_75_e6e6e6_1x400.png
./core/misc/ui/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png
./core/misc/ui/themes/base/images/ui-icons_2e83ff_256x240.png
./core/misc/ui/themes/base/images/ui-icons_454545_256x240.png

And maybe suffix patch with do-not-test since we know this won't affect tests in any way.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs work » Needs review
StatusFileSize
new 1830330-4-core-file_permissions.do_not_test.patch3.31 KB

Sure! I forgot to check if there were other files that had bad permissions, thanks!

kotnik’s picture

kotnik commented
Status: Needs review » Reviewed & tested by the community

Thanks. All good now.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1830330-1-core-default_settings_php_executable.patch, failed testing.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs work » Needs review

#1: 1830330-1-core-default_settings_php_executable.patch queued for re-testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Workflow timing; testbot came after the #5 status change.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

It will pop back once more, I have relaunched the test - I wonder what causes this to fail the bot.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Needs work

Those other files are part of jQuery UI, not Drupal itself, so we shouldn't be changing them. If their permissions need to be changed it should be done upstream.

The original patch looks good, though. This has been annoying me for a while since I have an installation script that tends to reset file permissions inside sites/default (which then causes a diff to appear on this file), but I never got around to filing an issue :)

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 1830330-1-core-default_settings_php_executable.patch490 bytes

Reuploading the original patch and setting back to RTBC.

fabianx’s picture

fabianx commented

+1 for RTBC

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Fixed » Reviewed & tested by the community

This got switched back again when #1828612: hook_views_query_substitutions missing from hook_hook_info was committed.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

And again, since it was changed back after that one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.