For example node_views_query_substitutions is placed into node.views.inc, so it will not be loaded under certain cases
and so actual sql code might be broken.

CommentFileSizeAuthor
#7 1828612-followup-7.patch999 bytesDavid_Rothstein
#4 drupal-1828612-4.patch7.43 KBdawehner
#2 durpal-1828612-2.patch7.79 KBdawehner
#1 1828612.patch561 bytesdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 1828612.patch561 bytes
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new durpal-1828612-2.patch7.79 KB

It's too later to figure out the test failures

Status: Needs review » Needs work

The last submitted patch, durpal-1828612-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-1828612-4.patch7.43 KB

Never write tests at night.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

This can easily cause Views to break, and the fix and tests are exactly right.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

David_Rothstein’s picture

David_Rothstein commented
Priority: Major » Normal
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new 1828612-followup-7.patch999 bytes

For some reason, the commit for this issue made weird changes to default.settings.php (even though they weren't in the above patch). It introduced some grammatical mistakes and rolled back #1830330: Make default.settings.php not executable... I think what happened is that it actually rolled back the last couple commits on that file, or something?

See: http://drupalcode.org/project/drupal.git/blobdiff/e318f1a6df45e135fdaf67...

The attached patch restores those.

catch’s picture

catch
he/him
Primary language English
commented

#7: 1828612-followup-7.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed the follow-up. The permissions had been fixed already but the docs changes still applied. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.