Static caching should not be disabled for file entities [#1750146]

I have no idea why in system_entity_info() we have 'static caching' => FALSE set to manually disable it. It makes no sense. We should allow the entities to be cached.

Comment	File	Size	Author
#1	file-static-cache.patch	487 bytes	jbrown
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jbrown CreditAttribution: jbrown commented 24 August 2012 at 09:56

Status:

Active

» Needs review

File	Size
file-static-cache.patch	487 bytes

Setting to TRUE to see if the tests pass.

Comment #2

24 August 2012 at 10:44

Status:

Needs review

» Needs work

The last submitted patch, file-static-cache.patch, failed testing.

Comment #3

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 24 August 2012 at 10:58

3 fails is better than I was expecting! I bet it's just a simple fix somewhere and we can make this change.

+++ b/core/modules/system/system.moduleundefined
@@ -284,7 +284,7 @@ function system_entity_info() {
-      'static cache' => FALSE,
+      'static cache' => TRUE,

We should actually just remove the 'static cache' line since it defaults to TRUE.