Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in schema.test over to PSR-0.

CommentFileSizeAuthor
#13 1598606.patch1.36 KBNiklas Fiekas
#10 convert_schematest_to_psr0-1598606-10.patch1.37 KBAlbert Volkman
#7 1598606.patch1.35 KBRobLoach
#6 convert_schematest_to_psr0-1598606-6.patch1.35 KBAlbert Volkman
#2 convert_schematest_to_psr0-1598606-2.patch1.26 KBAlbert Volkman
#1 convert_schematest_to_psr0-1598606-1.patch28.86 KBAlbert Volkman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Active » Needs review
FileSize
convert_schematest_to_psr0-1598606-1.patch28.86 KB

Converted.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
convert_schematest_to_psr0-1598606-2.patch1.26 KB

Ack, that's ugly. Try this instead.

Status: Needs review » Needs work

The last submitted patch, convert_schematest_to_psr0-1598606-2.patch, failed testing.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented

Looks like the problem is the same as in #1598620: Convert uuid.test to PSR-0. What commands/steps are you using to create the patch?

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

Since there is only one test in schema.test, we could probably just use the Common namespace?

Albert, this might help...

git clone --recursive --branch 8.x http://git.drupal.org/project/drupal.git
cd drupal
git checkout -b 1598606
git mv core/modules/system/tests/schema.test core/modules/system/lib/Drupal/system/Tests/Common/SchemaTest.php
MAKE THE CHANGES IN SCHEMATEST!!!
git add core/modules/system/lib/Drupal/system/Tests/Common/SchemaTest.php
MAKE THE CHANGES IN SYSTEM.INFO!!!!
git add core/modules/system/system.info
git status
CHECK YOURSELF BEFORE YOU WRECK YOURSELF!!!
git commit -m "Issue #1598606 by Albert Volkman: Convert schema.test to PSR-0."
git diff -C -M5% 8.x 1598606 > 1598606.patch

Patches sometimes get confused when there are files moving. Hopefully that'll help you figure out what was wrong.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
convert_schematest_to_psr0-1598606-6.patch1.35 KB

Thanks for the direction, Rob! I guess I'm still learning to do git properly. Let's give this a go.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs work » Needs review
FileSize
1598606.patch1.35 KB

Well done! Just needed a reroll for system.info.

Status: Needs review » Needs work

The last submitted patch, 1598606.patch, failed testing.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented

We need a reroll with another use statement for Exception: use Exception;.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Needs work » Needs review
FileSize
convert_schematest_to_psr0-1598606-10.patch1.37 KB

Added.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs quick reroll (probably due to clashing with other PSR-0 commits today, this doesn't apply with git apply any more).

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
1598606.patch1.36 KB

As always, the info file ;)

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Thanks. committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.