Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
poll.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Jul 2011 at 22:56 UTC
Updated:
29 Jul 2014 at 19:47 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tars16 commentedFirst attempt. Should we include the changes to the info file in these patches?
Did not do anything with the RTL styles.
Comment #2
tars16 commentedComment #3
tr commentedYes, the changes to .info should be in the patch.
Please read the Drupal CSS coding standards and use them in your patch: http://drupal.org/node/302199
Also, watch out for that "No newline at end of file" that you're putting in. Drupal coding standards say you should always have a newline at the end of the file.
Comment #4
bleen commentednote that this and #1229442: Convert poll tpls and markup to HTML5 are going to bump heads ... no big deal, but which ever gets committed first will require a reroll of the other
Comment #5
aspilicious commentedIt's possible this is incorrect as I'm a newb with creating command line patches
Comment #6
amateescu commentedpoll => Poll :) The same for every occurence.
Otherwise, tested the patch and it looks good to me.
Edit: Also needs a reroll to account for #1315616: A definition list for the poll results.
24 days to next Drupal core point release.
Comment #7
aspilicious commentedSecond try
Comment #8
aspilicious commentedBartik rtl love :)
Comment #9
amateescu commentedLooks good to me now.
Comment #10
webchickTagging for Jennifer.
Comment #11
jhodgdonIt doesn't look like any of the patches in the critical/major queue conflict with this, so I went ahead and committed it. Thanks!
Comment #12.0
(not verified) commentedUpdated issue summary.