jQuery 1.9 Milestone 2 comes with a Menu widget. You can demo the Menu widget as a contextual menu to see that it would fix perfectly into how we're using the menu with the Contextual Links module.

CommentFileSizeAuthor
#24 switch_contextuals_to_jquery_ui_menu-1169906-24.patch3.65 KBpwieck
#17 1169906-switch_contextuals_to_jquery_ui_menu-17.patch9.65 KBParisLiakos
#15 1169906-switch_contextuals_to_jquery_ui_menu-15.patch8.44 KBParisLiakos
#10 1169906.patch9.25 KBrobloach
#8 1169906.patch8.56 KBrobloach
#7 1169906.patch0 bytesrobloach
#5 Screenshot from 2012-06-30 22:46:13.png28.64 KBrobloach
#4 hmm.patch8.52 KBrobloach
contextmenu.png5.17 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented

Postponed for #1085590: Update to jQuery UI 1.9 and at least until we get a version of jQuery UI 1.9 in core that has the Menu widget.

aspilicious’s picture

aspilicious commented

sub

casey’s picture

casey commented

sub

robloach’s picture

robloach
he/him
commented
Status: Postponed » Needs review
StatusFileSize
new hmm.patch8.52 KB

Definitely needs some work, but it is getting there. So much less CSS.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new Screenshot from 2012-06-30 22:46:13.png28.64 KB

Here's a screenshot.

Status: Needs review » Needs work

The last submitted patch, hmm.patch, failed testing.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 1169906.patch0 bytes
robloach’s picture

robloach
he/him
commented
StatusFileSize
new 1169906.patch8.56 KB

Status: Needs review » Needs work

The last submitted patch, 1169906.patch, failed testing.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 1169906.patch9.25 KB

--binary

robloach’s picture

robloach
he/him
commented
Issue tags: +JavaScript
robloach’s picture

robloach
he/him
commented
Status: Needs review » Needs work

This needs work.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Needs review
Issue tags: -JavaScript, -jQuery UI, -Contextual links, -Proudly Found Elsewhere

#10: 1169906.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +JavaScript, +jQuery UI, +Contextual links, +Proudly Found Elsewhere

The last submitted patch, 1169906.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Needs review
StatusFileSize
new 1169906-switch_contextuals_to_jquery_ui_menu-15.patch8.44 KB

Simple reroll.
Definitely needs some css work and lot less js

Status: Needs review » Needs work

The last submitted patch, 1169906-switch_contextuals_to_jquery_ui_menu-15.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Needs review
StatusFileSize
new 1169906-switch_contextuals_to_jquery_ui_menu-17.patch9.65 KB

yes --binary needed

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Needs work

Back to needs work

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...the issue summary is back from May 2011 and the link to the demo is broken. I wanted to update it but I seem to not have edit rights for this specific issue. Locked or something? Anyways, the demos pages now are:

http://view.jqueryui.com/master/demos/menu/icons.html
http://view.jqueryui.com/master/demos/menu/default.html

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
Issue tags: -JavaScript, -jQuery UI, -Contextual links, -Proudly Found Elsewhere

#17: 1169906-switch_contextuals_to_jquery_ui_menu-17.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +JavaScript, +jQuery UI, +Contextual links, +Proudly Found Elsewhere

The last submitted patch, 1169906-switch_contextuals_to_jquery_ui_menu-17.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Needs reroll

Need to incorporate #1138844: Add touch support to contextual links

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
pwieck’s picture

pwieck commented
Issue tags: -Needs reroll
StatusFileSize
new switch_contextuals_to_jquery_ui_menu-1169906-24.patch3.65 KB

Rerolled to current head. WILL most likely fail, but maybe this will help bring life back to the issue.

pwieck’s picture

pwieck commented
Status: Needs work » Needs review

Status change

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 8.x-dev » 9.x-dev
Category: task » feature

It's now past api freeze.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes

Updated issue summary.

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.x-dev » 8.1.x-dev
Issue summary: View changes

Seems doable in a minor version.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Closed (won't fix)

Reasons for no longer doing this:

  1. This is no longer part of jQuery UI "core", it's been moved into a separate plugin: http://plugins.jquery.com/ui-contextmenu/.
  2. We now have "dynamic context menu items", e.g. for in-place editing, which aren't supported by jQuery UI Menu/Context Menu AFAICT.
  3. Contextual links now have optimized keyboard access also, which is toggleable from the toolbar. This is impossible to do with jQuery UI Menu AFAICT.