PHP 7 compatibility

We are getting the same error.

user@server:~/www$ drush pm-enable droogle
The following extensions will be enabled: droogle
Do you really want to continue? (y/n): y
PHP Fatal error: Redefinition of parameter $redirect_uri in /home/user/www/sites/all/modules/droogle/droogle.module on line 269
Drush command terminated abnormally due to an unrecoverable error. [error]
Error: Redefinition of parameter $redirect_uri in /home/user/www/sites/all/modules/droogle/droogle.module, line 269

We are running the following:
**Ubuntu 16.04 lts
**nginx version: nginx/1.10.3 (Ubuntu)
**mysql Ver 14.14 Distrib 5.7.19, for Linux (x86_64) using EditLine wrapper
**PHP 7.0.22-0ubuntu0.16.04.1 (cli) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.0.22-0ubuntu0.16.04.1, Copyright (c) 1999-2017, by Zend Technologies

Yes, also getting this error.

Running:
ubuntu server 16.04
php 7
apache
mysql

drupal 7 - latest version

Project droogle (7.x-4.0-beta15) downloaded to /var/www/html/bl3/web/sites/all/modules/droogle. [success]
The following projects have unmet dependencies: [ok]
droogle requires xautoload
Would you like to download them? (y/n): y
Project xautoload (7.x-5.7) downloaded to /var/www/html/bl3/web/sites/all/modules/xautoload. [success]
The following extensions will be enabled: droogle, xautoload
Do you really want to continue? (y/n): y
PHP Fatal error: Redefinition of parameter $redirect_uri in /var/www/html/bl3/web/sites/all/modules/droogle/droogle.module on line 269
Drush command terminated abnormally due to an unrecoverable error. [error]
Error: Redefinition of parameter $redirect_uri in /var/www/html/bl3/web/sites/all/modules/droogle/droogle.module, line 269

Jeff

I found this tidbit:

New in PHP7:
Function parameters with duplicate name are not allowed anymore. Definitions like “function foo($x,$x) {}” will lead to compile time error.

I'm not familiar with creating a patch to share with the community, so I will leave that for someone else for now, but as a temporary solution I modified the function call on line 269 of droogle.module:

function droogle_gdrive_connect($redirect_uri = NULL, $client_id = NULL, $client_secret = NULL, $redirect_uri = NULL) {

to

function droogle_gdrive_connect($redirect_uri = NULL, $client_id = NULL, $client_secret = NULL, $redirect_uri2 = NULL) {

and that allowed me to install the module. I'm sure this isn't the ideal method, but I just wanted to test to see if Droogle is going to work for my organization at all. Hope this helps some others!

Bringing this back up since I am now looking into using this module and have run across the same issue.. I would suggest from the code patch suggestion #2881669-4: PHP 7 compatibility that possiBri maybe submit this as a patch file follwing the guide in the Making a Drupal patch with Git page.

I would also suggest that if there is no function call that is calling out the whole spread of parameters, and that is the case at least in 7.x-4.0-beta15, that the second field simply be removed.

If you need any help with that let me know!

Hi All,

I am a new maintainer of the module, I saw that there were many issues fixed and that had a fix for this issue as well, I am releasing the existing code in the beta16 version of the module, please give it a try and update.

Thanks,
Sadashiv.

No feedback received.

Thanks,
Sadashiv.