I am talking about http://drupal.org/patch/create

Point 7 says the following:

Now, create your patch file.

git format-patch origin/[version] --stdout > [description]-[issue-number]-[comment-number].patch

Note: Do not use a "#" in your filename as it does not work.

While this seems right, aftera few tests and actually reading some things around, I believe that an alternative should be noted. First, this creates a patch that outputs your real email address, which might be sensitive information for somebody. It also includes each commit as a different diff, making it hard to review by just looking at it, like with dreditor or something.

I know this might be address to the greater mass, but something in a more general approach should at least be mentioned.

For instance creating a patch with just

git diff origin/<version> > /path/to/filename.patch

and applying it with

patch -p1 < /path/to/filename.patch

The -p1 is because of the a/xxx b/xxx format on the diff, not sure if that can be customizable by the git comment.

Bear in mind I am new to git, but this looks more straightforward for both reviews and devs coming from svn/cvs.

Comments

arianek’s picture

Issue tags: +git, +developer

tags

aspilicious’s picture

Status: Active » Fixed

Actually this page has been rewritten since than :)

Status: Fixed » Closed (fixed)
Issue tags: -git, -developer

Automatically closed -- issue fixed for 2 weeks with no activity.