Closed (fixed)
Project:
Devel Accessibility
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
28 Sep 2014 at 09:33 UTC
Updated:
6 Jul 2015 at 02:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
BarisW commentedComment #2
tr commentedThis module needs a LOT of changes of changes at this point. Here is a large patch that makes it work in the current (as of today) version of Drupal 8.0.x. I've tested the announce part, but I don't know how to test the tabbing manager part since that never worked for me.
Comment #3
tr commentedSince the module is unusable and gives a WSOD in its current form, this qualifies as a critical priority bug.
Comment #4
mgiffordThat patch still applies nicely. I don't know how to effectively test this module though.
Comment #5
wim leersLooks splendid! :)
Sorry for the long delay.
Here are the final bits that need to be changed before this can be committed. If you want me to commit this first, and then fix it in a follow-up, or want me to make these changes, that's fine too. Again, sorry for taking so long!
These labels are missing.
Because we check this before making changes, we should also unconditionally set
$attachments['#cache']['contexts'][] = 'user.permissions';Comment #6
tr commentedYes, I'd prefer a commit now then fix in a follow-up.
I left the labels blank because I didn't know how to describe those variables without doing more work to figure out what exactly they were supposed to do (especially with regards to the tabbing manager). Plus, the labels aren't really used anywhere so they don't affect functionality.
Likewise, it would take me a little while to test out the cache context thing at this point, and since we're using this in an admin capacity I don't think it really makes a difference, even though it would be the correct thing to do.
Comment #7
wim leersFor some reason, the patch didn't apply, despite no commits having happened. Here's a straight reroll.
Comment #8
wim leersImplemented #5.
Comment #9
wim leersDammit, now I understand why it didn't apply: I didn't know Jesse Beach had pushed another commit! I thought I was on latest, but obviously I wasn't. So, #2 did apply, but the #8 interdiff is still relevant.
Sorry for the long delay, but this is now finally done!
Comment #11
tr commentedThanks!