In #2955312: Workspace update from upstream fails with timeout replication has been moved to run on cron. However the UI in Deploy still suggests that replication is running now.

Resolution
- Create a deployment entity for updates.
- Show the deployment entity as queued.
- Mark deployment entity as running once cron starts.
- Mark deployment entity as deployed once cron is run.
- Add a link to deployment overview in toolbar.
- Update status messages.

CommentFileSizeAuthor
#4 2965598-3.patch14.71 KBtimmillwood
#2 2965598-2.patch7.2 KBtimmillwood

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Active » Needs work
StatusFileSize
new 2965598-2.patch7.2 KB

Initial patch, depends on #2955312: Workspace update from upstream fails with timeout.

jeqq’s picture

jeqq commented
Issue tags: +needs documentation updates

This will need documentation updates: https://www.drupal.org/docs/8/modules/deploy.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2965598-3.patch14.71 KB

Adding "Deployments" link to toolbar.
Fixing failing tests.

Status: Needs review » Needs work

The last submitted patch, 4: 2965598-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jeqq’s picture

jeqq commented 
  1. +++ b/css/deploy.toolbar.css
@@ -10,3 +10,7 @@
\ No newline at end of file

    :)

Just a nitpick, will do also manual testing.

  • timmillwood committed 3d510ac on 8.x-1.x 
    Issue #2965598 by timmillwood, jeqq: Update deploy UI to better reflect...
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.