Problem/Motivation

We recently added permissions to Deploy module to restrict deployment to all workspaces (or remote locations). However this restriction prevents content editors from deploying content to a workspace they just created.

Proposed resolution

A "Deploy to own workspace" would allow them to deploy content to any workspace which they created.
A "Deploy to any workspace" will be good for sites which generate a lot of workspaces and need an "admin" type permission.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2946153-4.patch5.01 KBtimmillwood
#3 2946153-3.patch2.85 KBtimmillwood

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Title: Add a "Deploy to own workspaces" permission » Add a "Deploy to own workspaces" and "Deploy to any workspace" permission
Issue summary: View changes
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
StatusFileSize
new 2946153-3.patch2.85 KB
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Active » Needs review
StatusFileSize
new 2946153-4.patch5.01 KB

Adding a test

jeqq’s picture

jeqq commented
Status: Needs review » Needs work 
  1. +++ b/src/ReplicationAccessControlHandler.php
@@ -67,11 +68,33 @@ class ReplicationAccessControlHandler extends EntityAccessControlHandler impleme
+      return AccessResult::forbidden();

    I would be good to add a message about why the access is forbidden. 

  2. +++ b/src/ReplicationAccessControlHandler.php
@@ -67,11 +68,33 @@ class ReplicationAccessControlHandler extends EntityAccessControlHandler impleme
+      return AccessResult::forbidden();

    The same here.

  • timmillwood committed e823f34 on 8.x-1.x 
    Issue #2946153 by timmillwood, jeqq: Add a "Deploy to own workspaces"...
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Fixed

Thanks @jeqq, fixed on commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.