Drupal standards recommend sprintf() or string concatenation to build exception messages.
https://www.drupal.org/docs/develop/coding-standards/php-exceptions

Relevant to Exporter.php and Importer.php

CommentFileSizeAuthor
#2 default_content-do_not_translate_Exception_messages-2870422-2.patch1.85 KBaaronbauman

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new default_content-do_not_translate_Exception_messages-2870422-2.patch1.85 KB

Updates 3 exceptions to use sprintf instead of FormattableMarkup

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » andypost
Status: Needs review » Reviewed & tested by the community

Looks good to me

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

  • andypost committed 03953a6 on 8.x-1.x authored by aaronbauman 
    Issue #2870422 by aaronbauman, larowlan: Exception messages should not...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: andypost » Unassigned
Status: Reviewed & tested by the community » Fixed
Related issues: +#2691085: Schedule alpha 9 release

Thanx for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.