6585b42 added back the link managers which were redundant after 96e7a2d - which was made possible because of https://www.drupal.org/node/2484399

This was another bad-merge, just like #2682823: Fix broken merge results

Please see https://github.com/larowlan/default_content/pull/38

Comments

larowlan created an issue. See original summary.

matslats’s picture

matslats commented

I'm sorry I take full responsibility, I shouldn't have committed and I should have tested better, but I am still running my version, defaultcontent until default_content can do menu links!
I'm totally lost between all these issues and patches.
I've never created, submitted or committed a patch before.
When I committed this code, I didn't realise there were several people working on this module.
The 'link fix broken merge results' patch you linked to, didn't have a single + or - line, so I can't see that it does anything!
Meanwhile the stray 'debug' and the @entity_type.manager without quotes in services.yml don't seem to be addressed anywhere.
Now I can't see where the modules Relation and Type Link Mangers are set to override. Can it have been fixed already.
Wouldn't you just revert my bad commit?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Nah its all good, we can work together to fix it

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs issue summary update
Related issues: +#2691085: Schedule alpha 9 release

do we still need this link managers?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Fixed

No, see https://www.drupal.org/node/2484399 - we worked on that feature for core *for this module* - https://github.com/larowlan/default_content/pull/38 was where we went with the core functionality over our own link manager.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.