Improvements to date_popup module

+1 for this solution

Thanks a million for taking this on!

I tried it with this as my form field:

$form['datepicker'] = array(
    '#type' => 'date_popup',
    '#title' => 'Date Needed',
    '#date_weekday_disable' => array(0,1,2),
    '#date_date_min' => time(),
    '#date_date_max' => time() + 60*60*24*12,
    '#date_day_disable' => array(time() + 60*60*24*9, time() + 60*60*24*10),
    );

The #date_date_min and #date_date_max worked like a charm but nothing the #date_weekday_disable and #date_day_disable did nothing for me?

I am going to reinstall date module and reapply the patch to be sure.

If this works, it will be so incredibly helpful!

Reapplied the patch again. Tried changing to generic zen theme. Nothing seems to work.

Do you want me to try something else?

Just let me know.

I can confirm that the PHP validation is working for day disable and weekday disable.

I can also confirm that everything, including the javascript pop up, works on a new plain vanilla Drupal installation for me.

I had previously tested this with an existing site configuration of a production site that had a lot of other modules installed.

I am looking in to what is breaking it on my existing site. Drupal and all the contrib modules seem to be up to date, but I am looking at it trying to see if is just a bad piece of custom code or if there is another contrib module and/or theme conflicting with the patch.

I must have run the patch wrong? When I copied the date module over from the new Drupal install that was working, and replaced the whole date module on the regular site; everything worked. I have don't know why originally, some stuff seemed to work but not others, but I'm not complaining.

Sorry for the confusion. Great patch!

This is really awesome! I'm going to start moving forward with it.

Is there anything else I can do?

Great improvment done. If you have better knowledge of FAPI and Date Api maybe we can join forces to add this feature too #613614: User-friendly multiple date selection.

Also, I've updated the javascript and CSS files to the latest jQuery UI 1.6 versions, because the supplied files are too old: the appearance is much better with the new files.

This is not required as date will use the jquery_ui's datepicker if you have that module enabled and the latest jquery.ui lib installed. Also the jQuery UI version you have added is not minified and results in far much more code to get downloaded.

As for the patch, thank you. I need this support myself.

For those of us who use date_popup in CCK, it will be required that we can configure this when we edit a field. Could that functionality get added.

Thanks again for your work.
Jordan

subscribe

Jorrit - Found a bug in your code that is causing the weekend and day disable not to work.

Your jquery.inArray has it's variables reversed... it should be needle, haystack instead of haystack, needle.

So change:

var dayDisabled = jQuery.inArray(settings.dayDisable, date.getTime() / 1000) != -1;
var weekdayDisabled = jQuery.inArray(settings.weekdayDisable, date.getDay()) != -1;

to

var dayDisabled = jQuery.inArray(date.getTime() / 1000, settings.dayDisable) != -1;
var weekdayDisabled = jQuery.inArray(date.getDay(), settings.weekdayDisable) != -1;

and now it works great! Thanks for all your work!

subscribing

Hi Jorrit,
I have implemented the above provided patch and it is really awesome. I was wondering that how can I manage some of the settings, which are not in the original date_popup module. Then after a long search I came across this post and once again I am very thankful to you.

I have one more issue in my part.

My requirement is :- There is a date_popup field which takes the date of birth of a person during registration. I needed the validation that the person's age cannot be less than 15 years. Which I have achieved with the help of this going throug this post and applying the patch. But, the default_value in the date_popup field is not getting populated. I want to populate the default value as the date before 15 years.

Code:-

$form['account']['dob'] = array(
'#type' => 'date_popup',
'#title' => t('Date of birth'),
'#date_format' => 'm-d-Y',
'#default_value' => strftime('%m-%d-%Y',strtotime('-15 years')),
'#date_year_range' => '-100:-15',
'#date_date_max' => strtotime("-15 years"),
'#description' => t('Select date of birth'),
'#required' => TRUE,
'#element_validate' => array('user_register_extra_fields_validate'),
'#attributes' => array('readonly' => 'readonly',
'autocomplete' => 'off',
),
);

Just, now I realized that when I provide the format as 'Y-m-d' it is working fine but, I require date to be in the month-day-Year format.

Second issue :-

On changing the year in the year drop down the dates are shifting towards right side and sometimes they are out of the div, it is happening until any date is selected once any date has been selected this issue is not remaining, and also this issue is happening in the Garland theme but in Chameleon theme this issue is not there.

I am sorry if I have confused you, because believe me I am very very new to drupal world and this beautiful family.

Any or all help will be greatly appreciated.
Thank you,
Pradeep.

On hit and tiral method I kept on changing the formats in date_format and in the defualt_date and at one instance I got the right hit. I am really not getting the words to explain it.

I hope the below code will somewhat understandable.

Code :-
$form['account']['dob'] = array(
'#type' => 'date_popup',
'#title' => t('Date of birth'),
'#date_format' => 'm-d-Y',
'#default_value' => strftime('%Y-%m-%d',strtotime('-15 years')),//$edit['dob'],
'#date_year_range' => '-100:-15',
'#date_date_max' => strtotime("-15 years"),
'#description' => t('Select date of birth'),
'#required' => TRUE,
'#element_validate' => array('user_register_extra_fields_validate'),
'#attributes' => array('readonly' => 'readonly',
'autocomplete' => 'off',
),
);
In the date_format I have provided the format 'm-d-Y' and in the default_value I am extracting the date in the format of 'Y-m-d'. I do not know the logic behind it but it worked for me.

Thank you,
Pradeep

Fixing issue title and priority

@Jorrit
This patch contains changes for at least 2 different issues (adding configuration options & css changes), making the patch overly big, complex, and very difficult to review.

Please split the various issues into separate issues for review.

Also, the configuration option changes appear to be very similar to #510464: more control over settings... one of these issues should be a duplicate of the other.... which one would be best to proceed with?

Thanks

any news?

Another issue, #510464: more control over settings, addresses the same idea and we need to have a single issue with a single patch. I can't do anything at all until we have a single issue with a single patch. One of these has to be marked a duplicate and everyone needs to work on the other until we have a patch that everyone agrees will work.

Bump,
Can someone look into KarenS's comments in #21?

We only have a single issue now which is great. One thing missing from #510464: more control over settings though which is the ability to override and add any setting wanted:

Right now the patch is doing:

  $settings = array(...

What I would like to do, which was the key in patch #23 which was an updated version of patch #13 is this (from the issue mentioned above):

  $element_settings = is_array($element['#datepicker_settings']) ? $element['#datepicker_settings'] : array();
  $settings = $element_settings + array(...

This allows developers to override the default values provided by the date module.

You are missing that in

$settings = $theoverrides + $thedefaults;

The + operator appends elements of remaining keys from $thedefaults to $theoverrides, whereas duplicated keys are NOT overwritten.

That way, you are allowed to:

a) add more settings
b) replace default settings
c) and keep using default untouched settings, keeping the module original functionality.

in a more elegant way than a foreach. (don't know about which has the best performance).

That said, i still prefer the code at:

<?php
  $element_settings = is_array($element['#datepicker_settings']) ? $element['#datepicker_settings'] : array();
  $settings = $element_settings + array(...
?>

Jorrit, I think you need to brush up your php ;)

Example:

$arr1 = array(1 => 2, 4 => 6);
$arr2 = array(3 => 6, 4 => 10);
$arr1 + $arr2 == array(1 => 2, 3 => 6, 4 => 6); // TRUE
$arr2 + $arr1 == array(1 => 2, 3 => 6, 4 => 10); // TRUE

When doing array + array all of the first array values will be kept and all the new ones in the second array will be added

So the code

$settings = $element_settings + array(...

is what I would like which would allow to add any option to the settings array.

Great to see movement on this concept! Well done guys (and gals)!

I'm curious to know how far away from being committed to a dev version you think this is...

I'd like to start using it, but my git/diff knowledge is not up to speed yet to jump on board.

[update]
I've worked out diff ;-) "patch -p0 < date-improvements-625264-23.diff" worked a treat on Mac OS X.

I've tested this on an internal D6 website (our intranet). Results:

It seems the 'Today' button doesn't work (switches to the current month, but nothing more). Is this functionality working normally, or has this patch broken this...?

I tried applying this to a 'date_combo' form element #type (ie day + time) however it did not appear. Changing the #type to 'date_popup' worked, but I lost the time input facility.

Is there much work involved in ensuring the time input is maintained so that 'date_combo' form element #types can be used with this fantastic patch?

subscribing

Sub

Is there something similar for D7? Some settings to control the clickable dates in the popup. For example to disable the weekends or whatever pre-defined dates.
something like this
thanks

For anyone trying to get the patch in #23 working with D6 CCK, for now you can modify the datepicker via a form API #after_build function for the node form.

<?php
/**
 * Implementation of hook_form_alter() specific to mynode_node_form.
 */
function mymodule_form_mynode_node_form_alter(&$form, &$form_state) {
  $form['#after_build'][] = 'mymodule_mynode_node_form_after_build';
}

/**
 * After build handler for mynode_node_form.
 */
function mymodule_mynode_node_form_after_build($form, &$form_state) {
  $today = mktime(0, 0, 0, date('n'), date('j'));
  
  // Additional properties for the datepicker.
  $form['field_mydatefield'][0]['value']['#date_date_min'] = $today - 604800; // -1 week
  $form['field_mydatefield'][0]['value']['#date_date_max'] = $today + 31536000; // +1 year
  $form['field_mydatefield'][0]['value']['#date_datepicker_settings'] = array(
    'showOn' => 'focus',
    'gotoCurrent' => TRUE,
  );
  
  // We must run the date popup element back through date_popup_process()
  // to pick up and apply our changes.
  $element = $form['field_mydatefield'][0]['value'];
  $form['field_mydatefield'][0]['value'] = date_popup_process($element);
  
  return $form;
}
?>

Would the patch at #1143680: Add selector to date_popup element to allow additional options to be passed to jQuery datepicker be sufficient? That seems like the most general fix. If that will do what is needed, add a D6 backport to that issue and let's close this issue.

I committed #1143680: Add selector to date_popup element to allow additional options to be passed to jQuery datepicker for D7 and marked it for backport to D6. Closing this issue as a duplicate.