Closed (fixed)
Project:
Date
Version:
7.x-2.x-dev
Component:
Date Repeat API
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2012 at 06:14 UTC
Updated:
18 Jan 2015 at 13:06 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ParisLiakos commentedWell thats weird but if i switch #state from visible to invisible it works...i guess a core bug? dunno, but if someones has the same problem try this patch
Comment #3
ParisLiakos commented#1: 1810734-date_repeat_checkboxes_work_reversed-1.patch queued for re-testing.
Comment #5
ParisLiakos commentedw/e a migration exception..which is irrelevant with my one-line change
Comment #6
saratt commentedHi, I am having this issue now, were you able to find a solution. Thanks.
Comment #7
ParisLiakos commented@st455 did you try my patch at #1?
Comment #8
saratt commented@ParisLiakos, yes I did try that and it fixed it. I did notice another issue too. Even the exclude and include dates checkboxes were working in an opposite way i.e when i check Exclude dates checkbox the field for include dates was being enabled.
I figured the source of my issue was the jquery update. The issues i mentioned above started popping up when jquery was updated from 1.4.4 to 1.6.3. Downgrading jquery fixed the issues, didn't even have to apply the patch.
Thank you for the patch though.
Comment #9
ParisLiakos commentedaah..thanks for your feedback! i have updated jquery too..i guess thats why
Comment #10
Renee S commentedSo, this issue is happening with jQuery 1.6+. This fix worked for me. I extended it to additional/exception checkboxes as well, as they are also messed-up. (Looking in drupal_process_states it seems like it *should* work with visible, but... yeah, it doesn't. "visible" without a corresponding "invisible" appears to work fine on the radios and selects, but not the checkboxes, as far as I can tell. But just "invisible" is all that's needed.)
Tested on a fresh install with 1.5 and changing it to invisible/FALSE works in 1.5 as well. Is there any reason not to specify the inverse for users of jQuery 1.5 and below?
Implementing this fix would provide forward-and-backward compatibility and support anybody using higher jQueries.
Comment #11
cafuego commented#1: 1810734-date_repeat_checkboxes_work_reversed-1.patch queued for re-testing.
Comment #12
cafuego commentedCommitted to 7.x-2.x.
Comment #13
Renee S commentedQuick question, cafuego, did you commit the patch as is? This also happens with Additional/Exception checkboxes, which isn't addressed in the patch above. I can roll a patch for that also if needed.
Comment #14
cafuego commentedYup, I applied the patch from #1 as-is. Just re-open this issue and add the patch for the extra bit if you want.
Comment #16
ParisLiakos commentedprobably related #2018791: states.js is not compatible with jquery +1.6.1 because it use $.attr in the wrong way
Comment #17
cmonnow commentedJust for closure - the patch that was created for the related issue in ParisLiakos's link in #16 does in fact fix this issue (that is, the include/exclude bug that wasn't fixed here).
It's just a single line in core that changes "this.attr('checked')" to "this.is(':checked')" (https://www.drupal.org/files/states_0.patch).