Notice happens when adding exposed date filter (between) for the date from field.

CommentFileSizeAuthor
#19 date-views-select-validate-1464280-18.patch759 bytesgeerlingguy
#18 date-views-select-validate-1464280-18.patch0 bytesgeerlingguy
#14 date_views.patch758 bytesGeorgique
#12 date_views.patch715 bytesGeorgique
#7 date_views.patch723 bytesGeorgique
#1 date-views_exposed_filter-1464280-1.patch809 bytesdealancer

Comments

dealancer’s picture

dealancer commented
Status: Active » Needs review
StatusFileSize
new date-views_exposed_filter-1464280-1.patch809 bytes

Here is a patch. Please review.

Status: Needs review » Needs work

The last submitted patch, date-views_exposed_filter-1464280-1.patch, failed testing.

rylowry@gmail.com’s picture

rylowry@gmail.com commented

I was looking at another issue (http://drupal.org/node/1425774) where this notice was mentioned. Here is a workaround that got rid of the notice for me, though I'm not sure what caused the original problem.

function hook_form_alter(&$form, &$form_state, $form_id) {
  if ($form_id == 'views_exposed_form' && isset($form['field_your_date_field'])) {
    $form['field_your_date_field']['value']['#date_format'] = 'Y-M-d';
  }
}
dealancer’s picture

dealancer commented

Thanks for the snippet, it should work. However we would like to have a path.

The problem is when operator is between or between not, we don't have $form['field_your_date_field']['value'], instead we have $form['field_your_date_field']['min'] and $form['field_your_date_field']['max'].

nagiek’s picture

nagiek commented

The patch in #1 should work. Re-roll it?

Georgique’s picture

Georgique commented

Confiriming issue and subscribe

Georgique’s picture

Georgique commented
StatusFileSize
new date_views.patch723 bytes
nagiek’s picture

nagiek commented
Status: Needs work » Needs review

Setting bot

Status: Needs review » Needs work

The last submitted patch, date_views.patch, failed testing.

Georgique’s picture

Georgique commented

I don't know how to make patches in right format. Just think that my correction in code is right...

dealancer’s picture

dealancer commented

The first four lines of a patch a bit wrong. It should be 

diff --git a/date_views.module b/date_views.module
index 0f4e128..e54bbe3 100644
--- a/date_views.module
+++ b/date_views.module

instead of

diff --git a/a/date_views.module b/b/date_views.module
index 0f4e128..e54bbe3 100644
--- a/a/date_views.module
+++ b/b/date_views.module
Georgique’s picture

Georgique commented
Status: Needs work » Needs review
StatusFileSize
new date_views.patch715 bytes

Fixed patch

Status: Needs review » Needs work

The last submitted patch, date_views.patch, failed testing.

Georgique’s picture

Georgique commented
StatusFileSize
new date_views.patch758 bytes

I suggest there should be path to date_views directory. Next try =)

Georgique’s picture

Georgique commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, date_views.patch, failed testing.

khandra’s picture

khandra commented

Hello all,
in my humble opinion, the patch is not working because there is a missing parenthesis on the last line.
In current file I read:
foreach ($granularity as $part)

instead it should be
foreach ($granularity as $part) {

hope this helps!

geerlingguy’s picture

geerlingguy commented
Version: 7.x-2.2 » 7.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new date-views-select-validate-1464280-18.patch0 bytes

Patches should be against -dev branch, and need to be made against a git checkout, in the root folder of the date module. Read more here: Making patches for Drupal with Git.

Attached updated patch.

geerlingguy’s picture

geerlingguy commented
StatusFileSize
new date-views-select-validate-1464280-18.patch759 bytes

Well, it would help if I attached a real patch...

karens’s picture

karens commented
Status: Needs review » Fixed

I can replicate this. Fixed now. Thanks guys!

http://drupalcode.org/project/date.git/commit/0514a92

laraz’s picture

laraz commented

#19: Thanks. It worked for me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.