Running simpletests with E_STRICT enabled on Drupal 6 (with PHP 5.2.14) I get tons of strict notices: "Only variables can be passed by reference". Patch following.

CommentFileSizeAuthor
#1 strict_notices-1162962-1.patch675 bytesmikeryan

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Needs review
StatusFileSize
new strict_notices-1162962-1.patch675 bytes
kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented

I can confirm, this patch solves the strict warnings.

arlinsandbulte’s picture

arlinsandbulte commented
Status: Needs review » Fixed

Fixed. I modified the patch a bit to elimiate the intermediate variable and put everything back on one line.

Commit: http://drupalcode.org/project/date.git/commit/7797779

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Closed (fixed) » Needs review

Warning still exists.
array_pop and end uses the variable as reference, so it is not possible to do this in one line.
Patch #1 works fine.

arlinsandbulte’s picture

arlinsandbulte commented

Ah, yes. You are correct.
Thanks!

http://drupalcode.org/project/date.git/commit/d8e713c

arlinsandbulte’s picture

arlinsandbulte commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.