Events that span over a month are not displayed in other months [#1141012]

Hi,

I see how quickly the issue queue is moving here and how busy the maintainers must be, so apologies if this is an obvious issue...

I have worked through the debugging information instructions and searched for similar issues.

PHP Version 5.3.5 running on IIS
Date 7.x-2.x-dev
Calendar 7.x-2.x-dev
Views 7.x-3.x-dev
CTools 7.x-1.x-dev

I have a custom content type with a Date field. The Date field has a From and a To date. If I Set the From date to, say the 5th of April and the To date to the 20th of April, I see the event going nicely from the 5th to the 20th in the Month view, as expected.

However, if I set the From date to the 20th of April and the To date to the 5th of May, in the Month view I see the event from the 20th of April to the end of the month (april.png), as expected, but May is empty (may.png).

Looking at the SQL query Views is generating, this is not suprising. The query finishes up with:

(DATE_FORMAT(STR_TO_DATE(field_data_field_start_date.field_start_date_value, '%Y-%m-%dT%T'), '%Y-%m') = '2011-05')

So it's only looking at events with a start date equal to the month we're looking at. I need events that will span 6 months or so, so this is a significant problem for me.

Have I overlooked something, or is Calendar not designed for this?

Many thanks

Comment	File	Size	Author
#8	display-events-spanning-over-month-borders-properly-1141012-8.patch	2.83 KB	marcusx
	may.png	19.21 KB	Aeternum
	april.png	20.21 KB	Aeternum

Comments

Comment #1

akanik commented 13 May 2011 at 15:48

subscribe.

Comment #2

xenyo commented 21 May 2011 at 11:55

Similar issue to http://drupal.org/node/1147620 ?

Comment #3

Initsogar commented 26 May 2011 at 14:52

Same here. I was trying to fix it, but after I add both of date fields (from & to) in contextual filters, it shows all events properly, but duplicated.

Comment #4

tnightingale commented 30 May 2011 at 23:15

Subscribing

Comment #5

sonnenmann commented 29 June 2011 at 13:49

Subscribing

Comment #6

marcusx commented 29 June 2011 at 13:53

+1 same problem here

Comment #7

kylebcooke commented 30 June 2011 at 19:15

Comment #8

marcusx commented 8 July 2011 at 15:05

Status:

Active

» Needs review

Status	File	Size
new	display-events-spanning-over-month-borders-properly-1141012-8.patch	2.83 KB

Created a patch for this issue.

Maybe someone can replace $this->real_field . '2' (see comment below) with the proper function to get the value 2 field name as a further improvement. I couldn't find where to get this and had to put the "2" there pretty manually. Not nice, but its working.

Apply against the latest 7.x-2.x-dev version from today.

// Now that our table is secure, get our formula.
    if ($this->date_handler->granularity == 'month') {
      // Compare both from and to values to ensure dates spanning over month
      // borders are displayed properly.
      $granularity = date_granularity_format('month');
      $min_value = date_format($this->min_date, $granularity); 
      $max_value = date_format($this->max_date, $granularity);
      $field = $this->date_handler->sql_field($this->table . '.' . $this->real_field);
      $field = $this->date_handler->sql_format($granularity, $field);
      $field2 = $this->date_handler->sql_field($this->table . '.' . $this->real_field . '2'); //replace the string concat with the proper function that gives back the field_value2, instead of hacking the "2" into it
      $field2 = $this->date_handler->sql_format($granularity, $field2);      
      $placeholder_min = $this->placeholder();
      $placeholder_max = $this->placeholder();
      $this->query->add_where_expression($group, "$field <= $placeholder_min AND $field2 >= $placeholder_max", array($placeholder_min => $min_value, $placeholder_max => $max_value));
    }