Correct datatype for default value for checkboxes in admin form [#2821137]

The first time you go to the admin form after installing the module you get two instances of this error message:

Warning: Invalid argument supplied for foreach() i form_type_checkboxes_value() (rad 2390 av .../includes/form.inc).

The reason for this is that you use 0 as a default value for form elements of type 'checkboxes'. The value for that field type has to be an array.

Comment	File	Size	Author
#3	datalayer-correct_datatype_for_checkboxes-2821137-3.patch	727 bytes	ordermind
#3	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 14 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

21 October 2016 at 14:27

ordermind created an issue. See original summary.

Comment #2

ordermind CreditAttribution: ordermind commented 21 October 2016 at 14:27

Issue summary:

View changes

Comment #3

ordermind CreditAttribution: ordermind commented 21 October 2016 at 14:37

Status:

Active

» Needs review

File	Size
datalayer-correct_datatype_for_checkboxes-2821137-3.patch	727 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 14 pass

Comment #4

doublejosh CreditAttribution: doublejosh as a volunteer commented 25 October 2016 at 06:24

Priority:	Normal	» Minor
Status:	Needs review	» Reviewed & tested by the community

Thank you!

Comment #5

bridgeway04 CreditAttribution: bridgeway04 commented 12 February 2017 at 20:19

Version:

7.x-1.x-dev

» 7.x-1.1

I am getting the same error in v7.x-1.1 at the top of the configuration screen. I tried installing the patch using git apply -v but I get Skipped patch 'datalayer.admin.inc'?

If you can't tell, I am new to Get and applying patch files!

Brad

Comment #6

bighappyface CreditAttribution: bighappyface as a volunteer commented 25 February 2017 at 17:59

Tests fixed in #2855972: Automated test runs failing and test run is now successful for this patch. I am verifying once more before moving this forward.

Comment #7

25 February 2017 at 18:02

bighappyface committed cf2b01d on 7.x-1.x authored by ordermind

Issue #2821137 by ordermind: Correct datatype for default value for...

Comment #8

bighappyface CreditAttribution: bighappyface as a volunteer commented 25 February 2017 at 18:03

Status:

Reviewed & tested by the community

» Fixed

Manually verified the issue and the fix using simplytest.me. No notices are present on the datalayer configuration screen on the first visit after enabling the module with the patch applied.