Make data fields searchable. Patch coming soon.

CommentFileSizeAuthor
#6 552414-data_clearsearch.patch8.24 KBDavid Goode
#1 data_search.tar_.gz2.88 KBalex_b

Comments

alex_b’s picture

alex_b commented
Status: Active » Needs review
StatusFileSize
new data_search.tar_.gz2.88 KB

Module by YHahn.

alex_b’s picture

alex_b commented
Status: Needs review » Needs work

Only data tables with a PK can be indexed. User shouldn't be able to enable indexing on other tables. Right now it looks like that's possible.

alex_b’s picture

alex_b commented

Needs to support deleting items from index that are removed from data table. Does not need to be encapsulated in DataTable::save() but can be a separate API function data_search_remove($data_table, array($id..)) ?

Ideally, we can support removing indexes in bulks not just id per id.

alex_b’s picture

alex_b commented

.install modifies search tables. This will only work if data_search is actually being installed after search when installed in an install profile or when being enabled at once.

David Goode’s picture

David Goode commented

Drupal sorts modules with dependencies higher than the module they depend on under normal circumstances -- see install.inc's function drupal_install_modules($module_list = array()). #4 should be a non-issue.

Also, the search indexing removal is supported in a forthcoming patch that removes any orphaned search entries (in bulk, with a single query) when it updates the index, generally on cron after being called by search.

David Goode’s picture

David Goode commented
StatusFileSize
new 552414-data_clearsearch.patch8.24 KB

Aforementioned patch with orphaned search entry removal.

alex_b’s picture

alex_b commented
Status: Needs work » Fixed

This is committed, thank you.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.