when editing, the select box that displays the repo's (contributions, drupal) it doesn't have any selected even though something was selected.

Comments

nedjo’s picture

Status: Active » Fixed

This is now fixed.

Anonymous’s picture

thanks

Anonymous’s picture

Status: Fixed » Closed (fixed)
dww’s picture

Title: repo field doesn't hold it's value » repo field doesn't hold its value
Project: Project » CVS integration
Version: » 6.x-1.x-dev
Component: Issues » User interface
Assigned: Unassigned » dww
Priority: Normal » Critical
Status: Closed (fixed) » Active

this is really a bug in the cvs.module. it's still active, and easily reproducable, both on drupal.org and on a test site. it's crazy to use a multiselect widget for this, since there should only be 1 valid choice per project, anyway. i'll try to roll a quick patch to make this a drop-down (that defaults to contributions) and see if that fixes things.

dww’s picture

Status: Active » Needs review
StatusFileSize
new1020 bytes

heh, trivial fix. there was confusion over what the field name was supposed to be ('cvs_repository' vs. 'repository'). by making everything consistent ('cvs_respository') it all works now. while i was at it, i turned this into a drop-down select instead of a multi-select, since there should only ever be 1 repository for a given project.

dww’s picture

StatusFileSize
new4.65 KB

and here's the holy grail patch for this bug. ;) now, there are a few new options in admin/settings/cvs:
'Default CVS repository for projects' (radio select for all repo names) and 'Projects that can select their CVS repository' (autocomplete text field for comma-separated list of project titles). i heavily stole from taxonomy_autocomplete() to get this project_autocomplete() working, happy with the commas, etc. any projects not in this text field can *not* select their repo, and will be forced to use the default repo.

the idea is that the drupal project itself would be listed in there, and would then be allowed to select the "drupal" repo. otherwise, everything would just have a select box with a single option for 'contributions'. it's pretty slick. ;) try it out. i think this is definitely the way to go for drupal.org, yet i tried to keep it flexible enough to be useful for other sites, too.

Anonymous’s picture

tested.. +1

killes@www.drop.org’s picture

looks good but I don't have a test setup.

dww’s picture

Status: Needs review » Reviewed & tested by the community

after consultation w/ killes in IRC, i applied the patch from #6 to HEAD and backported the project specific changes (which is just the autocomplete callback) to DRUPAL-4-7. still needs to be updated onto drupal.org. i'm therefore leaving the status as RTBC. we talked about maybe reviving scratch.drupal.org as a test bed for this stuff...

dww’s picture

Status: Reviewed & tested by the community » Fixed

killes updated drupal.org. seems to be working now.

dww’s picture

Status: Fixed » Needs review
StatusFileSize
new845 bytes

ugh, bug in that last patch. here's the fix.

dww’s picture

StatusFileSize
new843 bytes

typo in the last patch. this one's been tested now. sorry. (that's what i get for trying to rush this stuff).

dww’s picture

patch from #12 applied as revision 1.104.

dww’s picture

Status: Needs review » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)