Installing all currencies as default config is likely a performance problem, find an alternative

What about adding an Import currency local action next to Add new currency, and provide a selection form that lists all currencies. The user picks one, and the currency is immediately imported. The user can then either be redirected to the entity list, or to the edit form of the imported currency to make some possible final changes.

I haven't looked into this yet, but do you know how easy it is to import config into a full entity object? Is the config entity import code reusable enough?

I don't think the way admin/config/regional/language/add does it is good UX. You have to read the help text to understand that adding a custom currency requires you to select the last option from the list. I'd like the Currency UI to communicate the two possible actions more clearly than this.

I hadn't followed the link yet. Thank you. It's exactly what we need.

The config import example code you linked to was very useful. Thanks!

This patch has a working solution (without test coverage as I approached this from the UI side first). It feels unambiguous, except maybe for the fact that we have two local actions and newcomers may not understand the difference straight away.

If we use this solution, we will also need to remove currency_install().

The tests fail (mostly) because they expect currencies to be imported by default.

This patch does the same thing for currency locales, as there are a couple hundred of them as well. It also moved the import code to a dedicated service. It still needs test coverage.

I'm considering moving all currency metadata back to bartfeenstra/currency again after this, so the data can be maintained separately. This was done for Currency 7.x-2.x and the only reason this wasn't done for 8.x-3.x, is that I wanted default config to be imported on install.

- Added test coverage for the new code.
- Moved all default config to the same directory. This allows the code to be much simpler.
- The XXX currency is now imported upon installation, because it is the non-removable default currency.
- Shorthand array syntax.

And now including file moves instead of deletions.

Thanks!

Let's fail gracefully (and in accordance with the interface) when importing the same entities twice.

Issue has been closed 7 years ago :)

But I still have what to add here. I've attached small patch which allow easily import all currencies after module installation. I don't think it makes sense to import them during module installation because probably you don't need all of them. But the ability to import several currencies at once makes much sense for me.

So to import currencies go to /admin/config/regional/currency, click "Import a currency", select currencies you have to import and click "Import".

Hope this small patch will be useful for someone else.