Problem/Motivation

Automated test pipelines are currently failing on the 4.1.x branch.

This makes it harder to review, validate, and merge changes against the branch, because contributors cannot reliably tell whether a pipeline failure has been caused by their own change or by an existing issue in the branch/test setup.

The failing pipelines need to be investigated so that the branch has a reliable baseline again.

Steps to reproduce

  1. Open a merge request or issue fork targeting the 4.1.x branch.
  2. Run the GitLab pipeline.
  3. Review the pipeline test report.
  4. Confirm that one or more jobs fail independently of the specific change being proposed.

Proposed resolution

Investigate the failing pipeline jobs on the 4.1.x branch and make the required changes so that the test suite passes reliably again.

Remaining tasks

  1. Review recent failing pipelines on the 4.1.x branch.
  2. Identify the failing tests.
  3. Confirm that the failure is branch-wide rather than specific to one merge request.
  4. Apply the required fix.
  5. Rerun the pipeline.
  6. Confirm all required jobs pass.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork ctools-3600710

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kieran.cott created an issue. See original summary.

kieran.cott opened merge request !93

kieran.cott’s picture

kieran.cott
Location 🇵🇭 Manila
commented
Status: Active » Needs review

I’ve opened MR 93 to update tests, fixtures, coding-standards/static-analysis issues, and Drupal 11 compatibility expectations so the branch is aligned with the current CI tooling.

The latest commit addresses the CToolsWizardTest failure: the wizard service parameters had drifted out of sync with the constructor, causing the add wizard page to fatal before rendering, and the test config entity advertised a canonical link without a matching route. The changes restore the missing wizard parameters and add a real canonical route/controller for the test entity so both the add wizard and post-save collection page render cleanly.

kieran.cott’s picture

kieran.cott
Location 🇵🇭 Manila
commented
Assigned: kieran.cott » Unassigned
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thank you for taking the time to fix these issues, some of the fixes are incorrect but the scope of these changes are also a bit too big anyways. There might already be someone who fix them in the issue queue.

By making the scope broad you accidentally can create unintended merge conflicts in other issues that might be solving bug fixes.

Can you scope this to only the body field missing fixes? I know that one well enough to review it.
Then the scope can switch to just Phpunit

kieran.cott’s picture

kieran.cott
Location 🇵🇭 Manila
commented

Hi @joelpittet - thanks, I've reverted the changes in MR 93 except the body fields.

PHPUnit still fails on CToolsWizardTest, since commit 5a1495e01a58bee10fdf4efcb16d19544d96d1b6 is now reverted, but the scope of the MR is now reduced to the missing field.storage.node.body.yml and field.storage.block_content.body.yml config as suggested.