I've just done a check on the coding standards on the module file and noticed that a few docblocks are missing, also the URL module is included inline instead of using a use statement, will generate a patch

CommentFileSizeAuthor
#11 ctools_3035048-11.patch2.28 KBadityasingh
#9 3035048-9.patch2.73 KBshubham.prakash
#8 3035048-8.patch2.73 KBshubham.prakash
#3 docblocks-and-use-3035048-3-D8.patch2.73 KBdarrenwh

Comments

darrenwh created an issue. See original summary.

darrenwh’s picture

darrenwh commented
Title: Use statement and dockbloks on module file » Use statement and doc blocks on module file
darrenwh’s picture

darrenwh commented
Status: Needs work » Needs review
StatusFileSize
new docblocks-and-use-3035048-3-D8.patch2.73 KB

Attaching patch

darrenwh’s picture

darrenwh commented
Assigned: darrenwh » Unassigned
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented 
+++ b/ctools.module
@@ -50,12 +72,15 @@ function template_preprocess_ctools_wizard_trail_links(&$variables) {
+/**
+ * @param array $definitions
+ */

Which hook is this implementing?

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Version: 8.x-3.0 » 8.x-3.x-dev
Status: Needs review » Needs work
shubham.prakash’s picture

shubham.prakash commented
Assigned: Unassigned » shubham.prakash
shubham.prakash’s picture

shubham.prakash commented
Assigned: shubham.prakash » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3035048-8.patch2.73 KB

This patch should fix the issue.

shubham.prakash’s picture

shubham.prakash commented
StatusFileSize
new 3035048-9.patch2.73 KB

FIxed the Error

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch in #9 needs a reroll.

adityasingh’s picture

adityasingh commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new ctools_3035048-11.patch2.28 KB

Reroll the patch please review.