Using the Omega 7.31 theme.

Views Slideshow generates the height and width as an element style not only for the image, but for at least one div container for the image. This module adjusts the element styles for the slideshow image, but not the slideshow divs which have the element styles W and H. Doesn't seem to break the layout on width, but it does on height.

I am simply hard coding the width and height for the divs into the stylesheets as a workaround for the time being, but it would be good if the module could change the element styles for those divs as well.

Just wanted to let someone know, didn't see it in the issue queue. Very happy with the module overall :)

Comments

selinav’s picture

selinav CreditAttribution: selinav commented

+1

2pha’s picture

2pha
Primary language English
CreditAttribution: 2pha commented

-1
I hate it when modules set styles.
I don't think the views slideshow should be setting styles either. So many times things have been made harder because of modules such as views slideshow setting styles.

catarinavclemente’s picture

catarinavclemente CreditAttribution: catarinavclemente commented
David Lesieur’s picture

David Lesieur CreditAttribution: David Lesieur commented

I'm not sure what Client-side Adaptive Image could do here. I really don't see it messing with the styles of container elements! Perhaps it could trigger some events when an image is inserted/replaced, so that other modules could bind some additional processing. However, it seems unlikely that Views Slideshow would implement this extra processing.