Closed (fixed)
Project:
Crazy Egg Integration
Version:
7.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Nov 2011 at 16:52 UTC
Updated:
2 Oct 2014 at 15:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Scott Robertson commentedThe missing area is only used as a way of ensuring that the crazy egg tracking script isn't cached by adding a query string onto the end of the JavaScript link. This is handled automatically by Drupal, as when you call drupal_add_js(), it will attach a query string onto the end for you.
Comment #2
noahlively commentedGood point, s-robertson. I'm closing the issue.
Comment #3
slashrsm commentedI do not agree with that. That is true when you include JS files. But here we include JS in a inline form, so nothing is added ath the end of it. It would not help even if we'd add this code in a .js file, that would be added to a module. That would only mean, that our own file is not cached. It will not affect crazyegg's include.
Attaching patch...
Comment #4
noahlively commentedI have applied the patch to the 7.x-1.x branch and pushed up to the Drupal.org git repository.
Thanks, slashrsm
Comment #5
tunicI think this is fixed so I'm changing status
Comment #7
shaunlaws commentedI had to add a missing question mark to the patch to get it to work:
a.src=document.location.protocol+"//' . $script_host . '/' . $account_path . '?"+Math.floor(new Date().getTime()/3600000);
a.src=document.location.protocol+"//' . $script_host . '/' . $account_path . '?"+Math.floor(new Date().getTime()/3600000);Comment #8
shaunlaws commentedPatch file for comment #7