Problem/Motivation

For now only a dev release. When collectively between Soapbox and DROWL we are happy enough with it, would be good to make an alpha release.

Steps to reproduce

Proposed resolution

Both agree when we are happy enough with it

Remaining tasks

Make the release

User interface changes

API changes

Data model changes

Issue fork crawl_control-3623596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

Thanks @scott_euser! I'll review this within the next 2 days together with @grevil! (I'll temporarily assign him for that reason for a ping).
I'm totally fine with an alpha release at any time!

We'll come back here soon.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Note: We'll fix #3623960: Test, discuss and document default (exposed) filter behavior code-wise here.

grevil made their first commit to this issue’s fork.

grevil opened merge request !5

grevil’s picture

grevil commented
Status: Active » Needs review

Alright just some minor description adjustment and making "ignored_query_keys" an array, which we think makes more sense here :)

Please review! I think after this we can make an initial alpha release!

grevil’s picture

grevil commented

The tests failed because we are testing the old update hooks, which now use an old schema.

We could either update the old update hooks or remove the tests.

I don't think it is generally a good idea to update past update hook, so I dediced to remove the tests.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » scott_euser
Status: Needs review » Reviewed & tested by the community

Thanks @grevil, well done! RTBC and I think all makes sense.

Leaving this for @scott_euser to merge. Let's finish #3623948: List Crawl Control Views settings state on the settings page now and then I think we're ready for alpha1 once @scott_euser agrees (and doesn't want to resolve other issues before).

grevil’s picture

grevil commented

Thanks! Regarding #4, let's fix that in the other issue please.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Ok yes, sorry I thought you already included it here!