I appologize, this patch fixes a number of issues that should have probably been separated into different issues. But, with this applied, the module works against HEAD again.

Wasn't sure about "getEditableConfigNames", it never seemed to be called for me, just returned an empty array for now.

CommentFileSizeAuthor
#3 2408979-3.patch4.51 KBbenjy
#2 2408979-2.patch3.22 KBbenjy
config-devel.patch2.48 KBbenjy

Comments

Status: Needs review » Needs work

The last submitted patch, config-devel.patch, failed testing.

benjy’s picture

benjy commented
Status: Needs work » Needs review
StatusFileSize
new 2408979-2.patch3.22 KB

Might fix the tests.

benjy’s picture

benjy commented
StatusFileSize
new 2408979-3.patch4.51 KB

1 more fix, not sure about the schema errors.

The last submitted patch, 2: 2408979-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2408979-3.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Fixed

We should be good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.