When call composer command on Windows like "drush composer-manager update" Composer Manager throw exception and stop working.
I created a patch to fix that problem.

CommentFileSizeAuthor
#2 fix_composer_command_on_windows_2277883.patch649 byteszipme_hkt
fix_composer_command_on_windows.patch1.22 KBzipme_hkt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Active » Needs work

Thanks for reporting and submitting a patch.

If I read it correctly, we are not sanitizing the directory for Windows in any way, which I feel uncomfortable with. Are there other functions we can use to ensure that we aren't passing the value as-is? Marking as needs work to discuss the issue further.

Thanks!
Chris

zipme_hkt’s picture

zipme_hkt CreditAttribution: zipme_hkt commented
Version: 7.x-1.4 » 7.x-1.5
Status: Needs work » Needs review
FileSize
fix_composer_command_on_windows_2277883.patch649 bytes

After debug i find out problem is slash on windows.
i attached new path to fix that problem.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Needs review » Reviewed & tested by the community

Awesome! Thanks for digging in, and patch looks good to me.

Thanks for the contribution!
Chris

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Title: Composer Manager throw exception when call composer command on Windows » Composer Manager throws exception when composer commands are executed on Windows

  • Commit 0912468 on 7.x-1.x authored by zipme_hkt, committed by cpliakas: 
    Issue #2277883 by zipme_hkt: Composer Manager throws exception when...

  • Commit 5c0aea3 on 7.x-2.x authored by zipme_hkt, committed by cpliakas: 
    Issue #2277883 by zipme_hkt: Composer Manager throws exception when...

  • Commit 6ff9f21 on 6.x-1.x authored by zipme_hkt, committed by cpliakas: 
    Issue #2277883 by zipme_hkt: Composer Manager throws exception when...

  • Commit 8396cba on 6.x-2.x authored by zipme_hkt, committed by cpliakas: 
    Issue #2277883 by zipme_hkt: Composer Manager throws exception when...
cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Reviewed & tested by the community » Fixed

  • Commit d20a7b8 on 8.x-1.x authored by zipme_hkt, committed by cpliakas: 
    Issue #2277883 by zipme_hkt: Composer Manager throws exception when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.