The following commit removes a required include. It replaces a require statement with module_load_install but the required composer_manager.writer.inc is no longer imported.

http://drupalcode.org/project/composer_manager.git/commitdiff/e8fb7ba385...

CommentFileSizeAuthor
#1 composer_manager-2203569-missing-include.patch1.03 KBpsynaptic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented
FileSize
composer_manager-2203569-missing-include.patch1.03 KB

Patch attached which removes the module_load_install and replaced it with module_load_include since the only dependency it has is a function from composer_manager.writer.inc.

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented
Status: Needs work » Needs review
cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Priority: Major » Critical
Status: Needs review » Reviewed & tested by the community

Looks good to me. Thanks for the contribution!

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Reviewed & tested by the community » Fixed

I see where the issue came from. Modified patch slightly to also put the module_load_include() where I initially intended to.

Committed at http://drupalcode.org/project/composer_manager.git/commit/acbb80c.

Thanks for the contribution!
Chris

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented

Ported change to D7 as well to keep the codebase close, using module_load_include is probably more reliable anyways.

http://drupalcode.org/project/composer_manager.git/commit/12a53b8

psynaptic’s picture

psynaptic CreditAttribution: psynaptic commented

Thanks Chris, you are an amazingly responsive maintainer!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.