Closed (fixed)
Project:
Community Tags
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Aug 2008 at 20:16 UTC
Updated:
11 Sep 2009 at 22:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
OneClickVentures commentedThis patch for the 5.x version fixes this version as well (line numbers are off, I'm sure):
http://drupal.org/node/159479#comment-581505
Comment #2
danielnolde commentedhaving the same problems. is this fixed in the 6.x-dev version?
Comment #3
danielnolde commentedpatch seems to work for 6.x
Comment #4
dnewkerk commentedSubscribing... will test the patch as well and report back.
(no, it is not fixed in the 6.x-dev 2008-Aug-23 version yet)
Comment #5
owahab commentedNo patches here so moving it to active.
Comment #6
davidseth commentedHere is a proper patch for 6.x-1.x-dev.
Comment #7
andreiashu commentedThe patch from #6 provided by david is already included in the latest dev snapshot of the module.
Comment #8
bob_hirnlego commentedYes, the patch #6 is included but it shouldn't be.
In latest 6.x-1.x-dev release @ line 370 I read:
which is wrong.
It seems to me that #6 diff should be the other way around.
Comment #9
loze commentedit is backwards.
I switched the +'s for -'s in #6 and it looks like it worked.
Comment #10
tiantian20007 commentedYes, the patch in #6 fix this bug. However, another bug come up : If the node is in the forum , new Tagging erases the forums' taxonomy ! The node will no longer in the forum after tagging.
Comment #11
fractile81 commentedI also had this problem, and applying the reverse of the patch in #6 appears to have fixed the problem for me as well.
Quick question to everyone with this problem: were you only losing terms that were in your first vocabulary (vid 1)? Being curious, I'm looking at the old code to see why there was a problem to begin with. It looks like the
$community_taggedarray was being passed as the value for a single%d. It also appears that sites with more than one vocabulary configured for community tags may have not been working correctly. The opposite of what's in the patch in #6 (switch around the -'s and +'s) fixes both of these problems, as far as I can tell.Comment #12
Tim Chan commentedYa, I have the first vocabulary for categories and the second for community tags. I used the latest dev snapshot which includes the patch in #6. But the bug was still there i.e. the category became blank on node edit page. So I applied the reverse of the patch in #6 and it works. Weird.
Comment #13
WildBill commentedSorry, it's not clear to me whether the latest dev version has fixed this problem. My understanding is no - that the latest dev version still requires patching so that Community Tags won't delete terms in an unrelated vocabulary.
This bug is critical and renders the module unusable for me. Could someone update the dev snapshot with a fixed version? Better yet, if we could also fix "Cannot delete tags using My Tags X" it would destroy what are in my opinion two seriously important bugs.
Comment #14
ankheg commentedFor me #6 + #9 solved the problem.
Comment #15
marcoBauli commentedsame here, #6+#9 made things work again.
@fractile81: yep, vocabulary 1 only here too
Comment #16
drupalok commentedso... is this gonna be in a release or do i have to patch?
thanks for this cool module!
Comment #17
jcmarco commentedI have tested last #6+#9 patch and works fine as the rest of people that already have reported it.
I attach the patch re-rolled in the right format.
Comment #18
entrigan commentedthanks jcmarco and david seth, I will commit this tomorrow.
Comment #19
entrigan commentedcommitted