Undefined index errors [#2200151]

Hi,

When going to the td_redirect callback without URL parameters, there are couple PHP notices:

Notice: Undefined index: tduid in commerce_tradedoubler_callback() (line 54 of /var/www/builds/build_2014-02-18-134533/sites/all/modules/contrib/commerce_tradedoubler/commerce_tradedoubler.module).
Notice: Undefined variable: url in commerce_tradedoubler_callback() (line 62 of /var/www/builds/build_2014-02-18-134533/sites/all/modules/contrib/commerce_tradedoubler/commerce_tradedoubler.module).

Patch follows.

Comment	File	Size	Author
#1	commerce_tradedoubler-undefined-indexfix-2200151-1.patch	1.99 KB	iSampo
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

iSampo CreditAttribution: iSampo commented 19 February 2014 at 08:33

Status:

Active

» Needs review

File	Size
commerce_tradedoubler-undefined-indexfix-2200151-1.patch	1.99 KB

Here's patch for the undefined index errors. Also fixed a typo on the watchdog message and reformatted the watchdog message so the URL parameters are printed separately instead of after each other without spaces.

E: It seems my editor also stripped some trailing white spaces there. Oh well. :)