We should follow the change made in #2888665: Square configuration form broken with latest Commerce changed for Drupal 8 version. This moves the Square app configuration, and OAuth flow, to its own form. The payment methods can have a configuration for which location they're for.

One configuration, but multiple methods allowing each location.

CommentFileSizeAuthor
#8 move_square-2908012-8.patch34.25 KBmglaman
#6 move_square-2908012-6.patch33.9 KBmglaman
#4 move_square-2908012-4.patch32.65 KBmglaman
#3 move_square-2908012-3.patch30.18 KBmglaman
#2 move_square-2908012-2.patch27.7 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Active » Needs work
FileSize
move_square-2908012-2.patch27.7 KB

Initial patch. Configuration works fine.

Need to address:

  1. Test a transaction
  2. Upgrade path
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
FileSize
move_square-2908012-3.patch30.18 KB

Adds the upgrade path, just need to test transactions.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
move_square-2908012-4.patch32.65 KB

This patch has fixed upgrade and checkout payment works.

Status: Needs review » Needs work

The last submitted patch, 4: move_square-2908012-4.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
move_square-2908012-6.patch33.9 KB

Fix linting, and update README.

Status: Needs review » Needs work

The last submitted patch, 6: move_square-2908012-6.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
move_square-2908012-8.patch34.25 KB

More linting fixes.

  • mglaman committed 29a21ca on 7.x-1.x 
    Issue #2908012 by mglaman: Move Square configuration to own form,...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed

Configuration is now the same between Drupal 7 and Drupal 8 branch, simplifying documentation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.