Non draft orders are refreshed when editing shipments [#3328162]

Problem/Motivation

Whenever a shipment is added, edited, or removed the order is refreshed
https://git.drupalcode.org/project/commerce_shipping/-/blob/8.x-2.x/src/...

While this is fine for draft orders and carts it can lead to data loss when the order is refreshed for placed orders. Placed orders should not change unless expressly done by an administrator. The order refresh causes line item prices to be updated, promotions to be reevaluated, taxes recalculated.

When shipments are changed there are three things that do need to happen on placed orders:

The shipping adjustment total on the order needs to be updated to reflect the total cost of the shipments
The shipping promotions need to be recalculated. Other promotions need to remain untouched.
The tax for shipping, if applicable, needs to be recalculated and an event fired for any tax integrations to subscribe to

Steps to reproduce

Add, edit, or delete a shipment using the Shipments tab UI in the order administration area after an order has already been placed.

Proposed resolution

Trigger a shipping specific order refresh on non draft orders.

Possible ways of doing this:
Call the provided functions that commerce_shipping defines for the order refresh to only refresh shipping specific parts of the order. Probably the wrong way.

Provide a shipment refresh service that handles the refresh similar to the core one but skips anything that is not related to shipping.

Comment	File	Size	Author
#4	3328162-non-draft-orders-are-refreshed-4.patch	1.82 KB	rhovland
#4
#3	3328162-non-draft-orders-are-refreshed-3.patch	1.85 KB	rhovland
#3	8.x-2.x: PHP 7.3 & MySQL 5.7, D9.5 140 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 December 2022 at 00:55

rhovland created an issue. See original summary.

Comment #2

rhovland CreditAttribution: rhovland commented 14 January 2023 at 00:51

Comment #3

rhovland CreditAttribution: rhovland commented 17 January 2023 at 21:56

File	Size
3328162-non-draft-orders-are-refreshed-3.patch	1.85 KB
8.x-2.x: PHP 7.3 & MySQL 5.7, D9.5 140 pass, 1 fail

Here's a patch that disables refresh unless it's a draft order and does the bare minimum: updates the shipping adjustments after shipment save.
As I argued in the related issue, non draft order edits should be in control of the administrative user and doing things that change the order in meaningful ways (taxes, promotions, etc) should be controlled by the admin user not an automated process.

If a store wants to honor the promotions they gave the customer at time of purchase or recalculate them should be up to the individual store.

Taxes are recalculated and records adjusted once the admin user is done making changes to the order. An automated refresh cannot predict when a good time to do that is.