Add the ability to print product labels, formatted for use with a label roll printer. The module will use the PHP Barcode Generator composer package and thus will have a dependency on Composer Manager.

Because the new label module will also depend on the jQuery Print library, I've decided to remove the jQuery Print library definition from the Receipt submodule and instead create a new Drupal Module specifically for the jQuery Print library. This way, both modules can simply have a dependency on it and we open it up for use on other, non-POS projects.

Comments

Scott Robertson created an issue. See original summary.

Scott Robertson’s picture

Status: Active » Needs review
StatusFileSize
new37.92 KB

Seeing if the tests will even run properly, what with Composer Manager needing to be configured and packages installed.

Scott Robertson’s picture

StatusFileSize
new37.79 KB

Bah, wrong patch...

The last submitted patch, 2: product_label_printing-2788143-2.patch, failed testing.

The last submitted patch, 2: product_label_printing-2788143-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: product_label_printing-2788143-3.patch, failed testing.

The last submitted patch, 3: product_label_printing-2788143-3.patch, failed testing.

Scott Robertson’s picture

I don't think in the patches' current state it's possible to have the tests pass. Thinking about it a bit more, it's probably beneficial to move the barcode generation functionality out of the base label modules so that the barcode generation portion isn't required if you just want some really basic labels.

Scott Robertson’s picture

Status: Needs work » Needs review
StatusFileSize
new190.14 KB

Moved barcode generation for the labels into a separate submodule.

Status: Needs review » Needs work

The last submitted patch, 9: product_label_printing-2788143-9.patch, failed testing.

The last submitted patch, 9: product_label_printing-2788143-9.patch, failed testing.

Scott Robertson’s picture

Status: Needs work » Needs review
StatusFileSize
new190.18 KB

Hm, I think this might be failing because of a bad dependency. The tests run OK locally, but not on DrupalCI.

Status: Needs review » Needs work

The last submitted patch, 12: product_label_printing-2788143-12.patch, failed testing.

The last submitted patch, 12: product_label_printing-2788143-12.patch, failed testing.

Scott Robertson’s picture

Status: Needs work » Needs review
StatusFileSize
new190.21 KB

Not sure what's going on with DrupalCI...I've fixed an unrelated issue with commerce_pos_label_get_label_formats, but that shouldn't have prevented the new label tests from running entirely.

Status: Needs review » Needs work

The last submitted patch, 15: product_label_printing-2788143-15.patch, failed testing.

The last submitted patch, 15: product_label_printing-2788143-15.patch, failed testing.

Scott Robertson’s picture

Status: Needs work » Needs review
StatusFileSize
new190.61 KB

Trying to move dependencies around and see if that helps the tests...

Status: Needs review » Needs work

The last submitted patch, 18: product_label_printing-2788143-18.patch, failed testing.

The last submitted patch, 18: product_label_printing-2788143-18.patch, failed testing.

Scott Robertson’s picture

Status: Needs work » Needs review
StatusFileSize
new190.17 KB

Checking to see if it's the jquery print dependency causing all this trouble.

The last submitted patch, 15: product_label_printing-2788143-15.patch, failed testing.

Scott Robertson’s picture

StatusFileSize
new190.23 KB

Trying to confirm that it's actually the jQuery Print dependency and not Libraries or jQuery Update

The last submitted patch, 15: product_label_printing-2788143-15.patch, failed testing.

Scott Robertson’s picture

Scott Robertson’s picture

Status: Needs review » Fixed

Pull request has been merged.

  • Scott Robertson committed 984dc05 on 7.x-2.x
    Issue #2788143 by Scott Robertson: Product label printing
    
  • dca9055 committed on 7.x-2.x
    Merge pull request #1 from s-robertson/product_labels
    
    Issue #2788143 by...
sharif.tanveer’s picture

Having this error when visiting the setting page of POS

Fatal error: Class 'Picqer\Barcode\BarcodeGeneratorPNG' not found in C:\Users\SharifMohammad\Desktop\xcode\sites\all\modules\commerce_pos\modules\label\modules\barcode\commerce_pos_label_barcode.module on line 50

Is it anything to do with the composer set up/ php barcode generator library ?

Thanks,
SM

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

trungonly’s picture

I also getting error as #28, cannot find inclusion for Class 'Picqer\Barcode\BarcodeGeneratorPNG'. Any solution?