As per the parent issue, move the ubercart migrations to its own submodule.

CommentFileSizeAuthor
#8 2897754-8.patch19.86 KBquietone
#7 2897754-7.patch20.02 KBquietone
#5 interdiff.txt10.43 KBquietone
#5 2897754-5.patch21.97 KBquietone
#4 interdiff.txt908 bytesquietone
#4 2897754-4.patch14.48 KBquietone
#2 2897754-2.patch14.18 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Title: Move uberccart to submodule » Move ubercart to submodule
Status: Active » Needs review
StatusFileSize
new 2897754-2.patch14.18 KB

Fix spelling error in title. And a patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2897754-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2897754-4.patch14.48 KB
new interdiff.txt908 bytes

Fix the tests.

quietone’s picture

quietone commented
StatusFileSize
new 2897754-5.patch21.97 KB
new interdiff.txt10.43 KB

Coding standard fixes. Plus change the d7 currency test to use the currency assertion test in the CommerceMigrateTestTrait.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Novice

#2894123: Move commerce to submodule landed so this needs a re-roll.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2897754-7.patch20.02 KB

Rerolled.

quietone’s picture

quietone commented
StatusFileSize
new 2897754-8.patch19.86 KB

There was a CurrencyTest in the old test directory.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Issue tags: -Needs reroll
quietone’s picture

quietone commented

@heddn asked on IRC why the rerolled patch has one less file in it than the previous patch.

It is because there were 3 versions of the CurrencyTest in the previous patch

diff --git a/tests/src/Kernel/d6/Ubercart/CurrencyTest.php b/modules/ubercart/tests/src/Kernel/Migrate/d6/CurrencyTest.php
diff --git a/tests/src/Kernel/d6/Ubercart/CurrencyTest.php b/modules/ubercart/tests/src/Kernel/Migrate/d7/CurrencyTest.php
diff --git a/tests/src/Kernel/d7/Ubercart/CurrencyTest.php b/tests/src/Kernel/d7/Ubercart/CurrencyTest.php

The rerolled patch removed /tests/src/Kernel/d7/Ubercart/CurrencyTest.php.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Perfect.

  • heddn committed fe824fd on 8.x-2.x authored by quietone 
    Issue #2897754 by quietone, heddn: Move ubercart to submodule
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Novice

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.