Integrate Commerce File with Commerce Product Bundle

i have yet to get product bundles working locally to test. It appears that it would make the sub line items for each product. Commerce File operates on any line items that are marked as a 'product' in their definition. Specifically, Commerce File issues the licenses when the order is marked as "Completed" - thats the status used in the default Rule "Issue licenses on order update", which can be altered for your implementation.

Can you check that your orders are moving to the Completed status to issue the licenses.

If they are moving to Completed, then I suspect that the bundle module saves the actual product line items under their bundle line item type; therefore, re-work of commerce_file_license_issue_by_order() would be needed to handle bundle line items.

moving to dev

I did a bit of digging into this and got to a point where I could use some advice from the module maintainers. This is just a proof of concept and the final method of integration would need to be determined once this is working. Here's what I did:

First, I altered the following chunk of code in commerce_file_license_issue_by_order(), which is located in commerce_file.entities.inc (the plus lines are where I added code):

  // issue licenses for each line item
  foreach ($order_wrapper->commerce_line_items as $delta => $line_item_wrapper) {
+    // Handle normal commerce line items licences
    commerce_file_license_issue_by_line_item($line_item_wrapper->value(), $order, $updated_license_status);
    
+    // Handle licenses for any bundles.
+    if (module_exists('commerce_pbf')){
+      commerce_pbf_issue_sub_item_licenses($line_item_wrapper, $order, $updated_license_status);
+    }
    
  }

Then I created a small module with this one function (note the devel module debug lines in there):

function commerce_pbf_issue_sub_item_licenses(&$line_item_wrapper, $order, $updated_license_status) {
  dsm('called commerce_pbf_issue_sub_item_licenses');
  dpm($line_item_wrapper->getPropertyInfo());
 // Create a rendered version of the line item to pass to commerce_product_bundle
  $line_item = $line_item_wrapper->value();
  // Use commerce_product_bundle's function to get the sub items that are part of this bundle
  $sub_items = commerce_product_bundle_get_sub_line_items($line_item);
  //field_attach_load('commerce_line_item', $sub_items);
  // Go through each sub item
  dsm($sub_items);
  foreach($sub_items as $line_item_id => $item) {
    // HELP: We're missing file field on this line item, so this call back to commerce_file fails.
    commerce_file_license_issue_by_line_item($item, $order, $updated_license_status);
  }
}

The idea is that after normal line items are processed in commerce_file_license_issue_by_order(), we kick off to this new function that looks for sub items and calls commerce_file_license_issue_by_line_item() for each one we find. We can pass in the original order, because it is only being used to get the user who is purchasing.

After some debugging in commerce_file_license_issue_by_line_item(), I'm finding that the orders are still not being created because they don't have the file line items (as pointed out in the help comment above), so the code doesn't enter the main foreach statement there.

Next steps:

I'm struggling to figure out the proper way to add the file field to the sub line item. I'm also not sure that adding the file field to the sub line item would work, but my thought is that at least it will get us into the foreach statement where we're failing in commerce_file_license_issue_by_line_item(). Perhaps someone who is more familiar with how line items are constructed can weigh in?

Any news about this?????

i think this issue is identical to this #1401416: Digital Product Bundle
I plan to work on this when march ends..i will study those two modules till then.would be good to have some teamwork here,starting by a nice issue summary?

changing title:)

I just wanted to drop a quick note on where we left on this for our purposes. We backed out of this approach in favor of using filefield_source with commerce_file. This allowed us to have a product that has multiple files that already exist. This was closer to the functional requirements for our particular needs. However, our testing with that did uncover #1460308: Filefield_source file reference not giving access to files on other products, which is also not ideal.

hmm i have something ready...any feedback appreciated...
dunno if this module

• should be included with the main module
• should be a separate project
• shouldn't be a standalone module at all

i guess that is the maintainer's decision.

Some notes:
I couldnt get commerce_product_bundle_get_sub_line_items work with the line items... i was always getting an empty array, i guess it is because the add to cart button was provided by a view and not the standard product display
So i came up with a more generalized solution, to cover all cases...

(btw commerce_product_bundle is not needed at all for this to work)

All you have to do is

• create a product type
• add a product reference field with unlimited cardinality.

Thats it!

what do you mean

the licenses aren't issued successfully.

I didn't mess with rules at all.
I am just attaching the files to the product bundle line item, early when entity_load occurs, so that commerce_file will be triggered and issue the licenses when payment completes.
So after i buy a product bundle of commerce files, i get the licenses of the files that the bundle references under user/%/licensed-files view.
I can download the files from there.
sorry if i misunderstood here, or ignoring something

yes, i used 7.x-1.x-dev when developing this!

Thanks guys for working on this! I'm looking forward to using this feature :)

Yes i do have it and i believe this is the problem here

Subscribing. Not sure if this will fix my exact problem, but it might get me close.

I installed the patch as a module and I'm receiving this error when adding an album to the cart:

EntityMetadataWrapperException: There can be only numerical keyed items in a list. in EntityListWrapper->get() (line 918 of /..../sites/all/modules/entity/includes/entity.wrapper.inc).

Any ideas?

I have nearly the same error:

EntityMetadataWrapperException: There can be only numerical keyed items in a list. in EntityListWrapper->get() (line 953 of /.../sites/all/modules/entity/includes/entity.wrapper.inc).

I only get this error when I add a product to the cart that contains a product reference field. I also only get this error on pages that contain the cart block or the checkout page. Any help would be much appreciated. I am willing to pay for a solution.

Here is my site configuration:
Installed Drupal 7.7 with Commerce Downloads profile
Updated all modules to the most current versions and Drupal core to 7.14
Installed the Commerce File Bundle module

Can i create the product with commerce file from code? how? I've been searching the site and I cant find any help...How do I declare a commerce file field?

recrit
Sorry for posting this here,cant get enough help here
How do I add a commerce file product from code, My site allow users to upload file for processing and the system produce an output file that I want to add as commerce file product from code on a per user basis. I can't find any example of products created from code that includes a commerce file.

Thanks

@rootatwc, please correct me if I'm wrong, it looks like your patch will look for multiple commerce file fields on the commerce product entity and assign them to a line item when the line item is loaded?

If so, I see how this is a possible way to go. You could have a 'bundle' commerce_product configured per the commerce_product_bundle module that has multiple file fields on it, one for each file to be licensed in the bundle, and also include other 'bundled' products via reference fields in the usual way.

However, I'm more looking for an full integration between commerce_product_bundle and commerce_file, to wit ability to apply licenses to files from bundled products themselves. IE, if I have 3 bundled commerce_products referenced on my bundle product entity, and one of them has a commerce_file field, then I want to license that file when the bundle product is checked out from the cart. This way, I can sell my file license separately and bundle the product in a clean way.

Maybe it's a fine distinction...

i see:)

you are right, i believe it is a better approach

@rootatwc - thanks, glad that you agree. I think that I have a working module based on your start. I'll see if I have time to make a new sandbox for it tomorrow and we can share, ok?

I'm looking forward to this! This will surely be one of the most used extensions to Commerce File. Thank you for your dedication and hard work.

Posted in my sandbox. Please test, tnx!

http://drupalcode.org/sandbox/tbenice/1690422.git

I'm trying to get this to work with the latest version of commerce_file-7.x-1.x-dev.

On checkout I get, PHP Fatal error: Call to undefined function commerce_file_license_issue_by_line_item() in /var/www/drupal/sites/all/modules/commerce_file_integrate/commerce_file_bundle.module on line 116

@ponies: refer any issues with commerce_file_bundle to tbenice since that is his sandbox. This feature is not in the latest dev or beta4.

@tbenice:
The function has been changed to the following in the latest release.
commerce_file_license_issue_by_commerce_line_item($line_item, $updated_license_status = 'pending', $product_refresh = FALSE, $order = NULL)

I was able to get this working with a patch to @tbenice's module.

@tbenice: What happened to your sandbox? I would like to take a look at this and try to get it working on my site.

@ponies: Do you have the work you did? Could you post it here with an explanation of what you did to get it working?

Thanks

@ParisLiakos: I tried your patch in #9, despite the flaws agreed on in #24 as they wouldn't affect my use case. However, when I tried to add a bundled product to the cart I got this error:

EntityMetadataWrapperException: There can be only numerical keyed items in a list. in EntityListWrapper->get() (line 962 of /sites/all/modules/entity/includes/entity.wrapper.inc).

Unfortunately I don't understand your code well enough to understand what the problem is here.

Hi All, there is a new project https://drupal.org/project/commerce_file_bundle that covers it.

test it out and put any issues in that queue.

-Ted