Closed (fixed)
Project:
Commerce File
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
6 Jun 2011 at 05:54 UTC
Updated:
23 Jun 2011 at 04:11 UTC
Currently, the module adds a tab to the user profile page named "Licenses". After clicking on this tab, the resulting view is titled "File Licenses". I think this terminology is confusing to the end user because the tab doesn't really display "licenses" (the legal document that gives them the right to use the file)... Rather, it displays the specific files the user may access (that have been licensed).
So by default, I'd rather see the "Licenses" tab titled "Files" (or else "Licensed Files" or "Purchased Files"). And I'd change the title of the view to be "Files" as well.
--Ben
Comments
Comment #1
recrit commentedi agree the wording can be confusing. I went with "Licensed File" base wording and changed per commit 2954bf2. I feel thats a good start and then it can always be overridden in views.
Comment #2
torgospizzaI think as long as we're able to override it (or create our own View later) it doesn't really matter what it's called, though if the main focus of this module is to allow the sale of Files, it should probably be called that as the default. That way when you install "Commerce File" you are looking for anything that says "Files" - you might skip over it otherwise.
Comment #3
recrit commentedset to "Files" now per commit 975a203
Comment #4
BenK commentedYeah, the "Files" tab looks nice (and shorter!). But now that the tab says "Files," should the path also be /user/[uid]/files (instead of /user/[uid]/licensed-files)?
--Ben
Comment #5
recrit commentedi think the url should stay some what commerce / purchased file specific. Other modules might use the generic "files" for some other use such as files they have uploaded to the site, etc.
Comment #6
torgospizzaThanks, recrit!
Comment #7
recrit commentedmarking as fixed for now.. if anyone objects you can reopen the discussion.