The discount edit form works some dark magic to render the offer type selection radio buttons element and get the offer's fields to appear to the right of the radio buttons list. This aggressive floating causes issues for offer types that have a large number of fields, such as the BOGO offers enabled by https://www.drupal.org/project/commerce_discount_extra. It's also just unnecessary.
Instead, we can wrap all offer fields in a div and float that to the left to ensure proper positioning alongside the offer type selection radio buttons. Unfortunately, IEF currently depends on field elements being in the top level of the entity form, so we can't just attach the fields to a container. Instead we have to use a bit of a hack to wrap them using markup elements with appropriate weights.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | remove_aggressive-2532554-8.patch | 18.21 KB | joelpittet |
| #1 | 2532554.offer_fields_wrapper.patch | 3.44 KB | rszrama |
Comments
Comment #1
rszrama commentedPatch attached.
Comment #2
rszrama commentedThought I might wait to give the testbot a chance to fail again, but I'm just going to commit this. ; )
Comment #3
rszrama commented(Ok, fwiw, I'm waiting on a confirmation at #2099277-5: Move git services to new git servers before I reset my keys and push the commit up.)
Comment #6
joelpittet@rszrama there is a scss folder. I'm going to have to transpose your fixes back to sass.
Comment #7
joelpittetRe-opening this and will post and commit the fixes.
Comment #8
joelpittetHere's the same effective CSS output through SASS. Put in a readme.md for how to compile the CSS.
And still that SASS needs some love still, there is way too much nesting going on.
Comment #11
joelpittetComment #12
rszrama commentedShoot, I had no clue. Thanks for the assist!